Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#issuecomment-2913183379

   Hello @amogh-jahagirdar, 
   Because of this optimization, these delete manifest entries are never marked as EXISTING for the next snapshots. It shows as ADDED for the next snapshot instead of. EXISTING. Which results in wrong stats calculation. Since both ADDED and  EXISTING is considered as live, queries are working fine. But technically, it is wrong and should be marked as EXISTING.  
   
   In `ManifestFilterManager.filterManifest ', `canContainDeletedFiles` is returning false for DELETE manifests and is bypassing the logic to make them EXISTING. 
   
   I would like to hop on a call and understand this change better. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org