You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/02 02:39:13 UTC
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11730: Add Kubernetes configmap reload to all components
EricGao888 commented on code in PR #11730:
URL: https://github.com/apache/dolphinscheduler/pull/11730#discussion_r961239135
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/bootstrap.yaml:
##########
@@ -0,0 +1,28 @@
+#
Review Comment:
Since we have a new `bootstrap.yaml` configuration for all components, do we need to update https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/architecture/configuration.md and add some related instructions?
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/bootstrap.yaml:
##########
@@ -0,0 +1,28 @@
+#
Review Comment:
Since we have a new `bootstrap.yaml` configuration file for all components, do we need to update https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/architecture/configuration.md and add some related instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org