You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@usergrid.apache.org by sf...@apache.org on 2014/10/01 22:46:41 UTC
[1/2] git commit: move logging
Repository: incubator-usergrid
Updated Branches:
refs/heads/two-dot-o 1530bf7aa -> 74cca91ce
move logging
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/c9f8ab77
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/c9f8ab77
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/c9f8ab77
Branch: refs/heads/two-dot-o
Commit: c9f8ab7790ddb6b2e2d4be0ee7ee71332cce210b
Parents: 1530bf7
Author: Shawn Feldman <sf...@apache.org>
Authored: Wed Oct 1 14:28:59 2014 -0600
Committer: Shawn Feldman <sf...@apache.org>
Committed: Wed Oct 1 14:28:59 2014 -0600
----------------------------------------------------------------------
.../usergrid/services/notifications/ApplicationQueueManager.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/c9f8ab77/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
----------------------------------------------------------------------
diff --git a/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java b/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
index e730a6d..cb65e00 100644
--- a/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
+++ b/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
@@ -249,11 +249,11 @@ public class ApplicationQueueManager implements QueueManager {
LOG.info("ApplicationQueueMessage: notification {} done queuing to {} devices in "+elapsed+" ms",notification.getUuid().toString(),deviceCount.get());
}
- now = System.currentTimeMillis();
if(sendNow && messages.size()>0){
+ now = System.currentTimeMillis();
sendBatchToProviders(messages,null).toBlocking().lastOrDefault(null);
+ LOG.info("ApplicationQueueMessage: notification {} done sending to "+messages.size()+" devicess in {} ms", notification.getUuid(), System.currentTimeMillis() - now);
}
- LOG.info("ApplicationQueueMessage: notification {} done sending duration {} ms", notification.getUuid(), System.currentTimeMillis() - now);
}
[2/2] git commit: check for bad path
Posted by sf...@apache.org.
check for bad path
Project: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/commit/74cca91c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/tree/74cca91c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-usergrid/diff/74cca91c
Branch: refs/heads/two-dot-o
Commit: 74cca91ce345d116fe3c2eaaf6f0248d39a0ca78
Parents: c9f8ab7
Author: Shawn Feldman <sf...@apache.org>
Authored: Wed Oct 1 14:46:06 2014 -0600
Committer: Shawn Feldman <sf...@apache.org>
Committed: Wed Oct 1 14:46:06 2014 -0600
----------------------------------------------------------------------
.../usergrid/services/notifications/ApplicationQueueManager.java | 2 +-
.../org/apache/usergrid/services/notifications/TaskManager.java | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/74cca91c/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
----------------------------------------------------------------------
diff --git a/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java b/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
index cb65e00..a057f31 100644
--- a/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
+++ b/stack/services/src/main/java/org/apache/usergrid/services/notifications/ApplicationQueueManager.java
@@ -364,7 +364,7 @@ public class ApplicationQueueManager implements QueueManager {
} catch (Exception e) {
LOG.error("Failure while sending",e);
try {
- if(!messageCommitted) {
+ if(!messageCommitted && queuePath != null) {
qm.commitTransaction(queuePath, message.getTransaction(), null);
}
}catch (Exception queueException){
http://git-wip-us.apache.org/repos/asf/incubator-usergrid/blob/74cca91c/stack/services/src/main/java/org/apache/usergrid/services/notifications/TaskManager.java
----------------------------------------------------------------------
diff --git a/stack/services/src/main/java/org/apache/usergrid/services/notifications/TaskManager.java b/stack/services/src/main/java/org/apache/usergrid/services/notifications/TaskManager.java
index 07aed57..08f067d 100644
--- a/stack/services/src/main/java/org/apache/usergrid/services/notifications/TaskManager.java
+++ b/stack/services/src/main/java/org/apache/usergrid/services/notifications/TaskManager.java
@@ -32,8 +32,7 @@ import java.util.concurrent.atomic.AtomicLong;
public class TaskManager {
- private static final Logger LOG = LoggerFactory
- .getLogger(TaskManager.class);
+ private static final Logger LOG = LoggerFactory.getLogger(TaskManager.class);
private final QueueManager proxy;
private final String queuePath;