You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2024/03/20 23:46:20 UTC
[PR] Remove duplicate doubles sorted views (datasketches-java)
leerho opened a new pull request, #532:
URL: https://github.com/apache/datasketches-java/pull/532
This had a rippling effect across a number of files. This also includes some trivial fixes for spelling errors and other minor issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Remove duplicate doubles sorted views (datasketches-java)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on PR #532:
URL: https://github.com/apache/datasketches-java/pull/532#issuecomment-2016898348
Summary of changes by file:
**hllmap/**
- **UniqueCountMap** - added one line comment
**kll/**
- **KllDoublesSketch**
- changed variable kllDoublesSV to doublesSV
- Moved create from sketch code from SV to here
- **KllDoublesSketchSortedView** - removed
- **KllItemsSketch** - minor comment changes
**quantiles/**
- **CompactDoublesSketch** - fix spelling
- **DirectDoublesSketchAccessor** - added blank line
- **DirectUpdateDoublesSketch** - propagated variable name change
- **DoublesArrayAccessor** - line reformat
- **DoublesBufferAccessor** - line reformats
- **DoublesSketch**
- changed variable _classicQdsSV_ to _doublesSV_
- grouped the "SortedView" methods together at the bottom
- **DoublesSketchSortedView** moved from /quantiles/ to /quantilescommon/
- **DoublesUnionImpl** - propagated variable name change
- **HeapUpdateDoublesSketch** - propagated variable name change
- **ItemsSketch**
- Moved create from sketch code from SV to here (this had two revisions, which makes it more complex to view the diff)
- **KolomogorovSmirnov**
- This needs more work to remove the dependence on the specific classic DoublesSketch and use the SV directly. This will enable its use with KllDoublesSketch as well. This will have to be a separate PR.
- **DoublesSketchSortedView** - moved from quantiles to quantilescommon
**tdigest/**
- **TdigestDouble** - This was to fix a conflict caused by interleaved pushes to master from Alex and me.
**/test/...**
**quantiles/**
- **CustomQuantilesTest** - gets the SV directly from the sketch
- **UtilTest** - corrected the access point
**quantilescommon/**
- **CrossCheckQuantilesTest** - corrected the access points.
- **ReflectUtilityTest** - corrected the access points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Remove duplicate doubles sorted views (datasketches-java)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #532:
URL: https://github.com/apache/datasketches-java/pull/532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org