You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/15 03:11:12 UTC

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #13668: Update MKL-DNN to v0.18 release (was: fix the Dense layer issue)

wkcn commented on a change in pull request #13668: Update MKL-DNN to v0.18 release (was: fix the Dense layer issue)
URL: https://github.com/apache/incubator-mxnet/pull/13668#discussion_r261873804
 
 

 ##########
 File path: mkldnn.mk
 ##########
 @@ -40,6 +42,9 @@ $(MKLDNN_LIBFILE):
 	cmake $(MKLDNN_SUBMODDIR) -DCMAKE_INSTALL_PREFIX=$(MKLDNNROOT) -B$(MKLDNN_BUILDDIR) -DARCH_OPT_FLAGS="-mtune=generic" -DWITH_TEST=OFF -DWITH_EXAMPLE=OFF
 	$(MAKE) -C $(MKLDNN_BUILDDIR) VERBOSE=1
 	$(MAKE) -C $(MKLDNN_BUILDDIR) install
+	if [ -f "$(MKLDNN_LIB64FILE)" ]; then \
+		mv $(MKLDNNROOT)/lib64/libmkldnn* $(MKLDNNROOT)/lib/; \
 
 Review comment:
   Thanks for your contribution!
   
   It seems that the command will move the files each building.
   Could we check whether the files exist and replace 'mv' with 'ln -s'?
   
   The rest LGTM : )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services