You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/28 00:46:01 UTC

[GitHub] [pulsar] mattisonchao commented on pull request #15104: [cleanup] [broker] Remove useless code to avoid confusion in OpReadEntry#checkReadCompletion

mattisonchao commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1140121569

   This PR need to cherry-pick to another branch, because when invoke `cursor.ledger.startReadOperationOnLedger(nextReadPosition, OpReadEntry.this);` twice may cause NPE when ledger id equals `null` and then failed this `OpAddEntry` and recycle it.
   
   @codelipenghui  @horizonzy Could you help to confirm it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org