[GitHub] [thrift] Jimexist commented on a diff in pull request #2574: THRIFT-5560: use junit 5 for all java unit tests

[GitBox <gi...@apache.org>]

Jimexist commented on code in PR #2574:
URL: https://github.com/apache/thrift/pull/2574#discussion_r851829308


##########
lib/java/test/org/apache/thrift/TestStruct.java:
##########
@@ -48,7 +38,23 @@
 import thrift.test.StructB;
 import thrift.test.Xtruct;
 
-public class TestStruct extends TestCase {
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.nio.ByteBuffer;
+import java.util.HashMap;
+import java.util.Map;

Review Comment:
   @ctubbsii i agree with you but let me try to file up a jira - along with code formatting. see https://issues.apache.org/jira/browse/THRIFT-5561



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org