You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2016/01/19 10:50:11 UTC
mina-sshd git commit: Using a clone of the data in
X11ForwardSupport#doWriteData in order to avoid data buffer re-use by caller
Repository: mina-sshd
Updated Branches:
refs/heads/master c66c6d421 -> c857627ab
Using a clone of the data in X11ForwardSupport#doWriteData in order to avoid data buffer re-use by caller
Project: http://git-wip-us.apache.org/repos/asf/mina-sshd/repo
Commit: http://git-wip-us.apache.org/repos/asf/mina-sshd/commit/c857627a
Tree: http://git-wip-us.apache.org/repos/asf/mina-sshd/tree/c857627a
Diff: http://git-wip-us.apache.org/repos/asf/mina-sshd/diff/c857627a
Branch: refs/heads/master
Commit: c857627ab130751eddf23f233ad334cfc659ed97
Parents: c66c6d4
Author: Lyor Goldstein <lg...@vmware.com>
Authored: Tue Jan 19 11:50:02 2016 +0200
Committer: Lyor Goldstein <lg...@vmware.com>
Committed: Tue Jan 19 11:50:02 2016 +0200
----------------------------------------------------------------------
.../main/java/org/apache/sshd/server/x11/X11ForwardSupport.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/c857627a/sshd-core/src/main/java/org/apache/sshd/server/x11/X11ForwardSupport.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/server/x11/X11ForwardSupport.java b/sshd-core/src/main/java/org/apache/sshd/server/x11/X11ForwardSupport.java
index a73bb71..6edc918 100644
--- a/sshd-core/src/main/java/org/apache/sshd/server/x11/X11ForwardSupport.java
+++ b/sshd-core/src/main/java/org/apache/sshd/server/x11/X11ForwardSupport.java
@@ -234,7 +234,8 @@ public class X11ForwardSupport extends AbstractInnerCloseable implements IoHandl
@Override
protected synchronized void doWriteData(byte[] data, int off, int len) throws IOException {
localWindow.consumeAndCheck(len);
- serverSession.write(new ByteArrayBuffer(data, off, len));
+ // use a clone in case data buffer is re-used
+ serverSession.write(ByteArrayBuffer.getCompactClone(data, off, len));
}
@Override