You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/24 01:38:48 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13468: [Doc] add custom properties for the reconsumeLater

Anonymitaet commented on a change in pull request #13468:
URL: https://github.com/apache/pulsar/pull/13468#discussion_r774832167



##########
File path: site2/docs/concepts-messaging.md
##########
@@ -273,13 +273,33 @@ Consumer<byte[]> consumer = pulsarClient.newConsumer(Schema.BYTES)
                 .subscribe();
 ```
 
+Retry letter message contains some special property，automatically created by client.
+
+special property | Description

Review comment:
       ```suggestion
   Special property | Description
   ```

##########
File path: site2/docs/concepts-messaging.md
##########
@@ -273,13 +273,33 @@ Consumer<byte[]> consumer = pulsarClient.newConsumer(Schema.BYTES)
                 .subscribe();
 ```
 
+Retry letter message contains some special property，automatically created by client.
+
+special property | Description
+:--------------------|:-----------
+`REAL_TOPIC` | The real topic name.
+`ORIGIN_MESSAGE_ID` | The origin message id, it will be crucial for message tracking.
+`RECONSUMETIMES`   | The retry consume times.
+`DELAY_TIME`      | Message delay timeMs.
+

Review comment:
       
   ```suggestion
   **Example**
   ```

##########
File path: site2/docs/concepts-messaging.md
##########
@@ -273,13 +273,33 @@ Consumer<byte[]> consumer = pulsarClient.newConsumer(Schema.BYTES)
                 .subscribe();
 ```
 
+Retry letter message contains some special property，automatically created by client.

Review comment:
       ```suggestion
   Retry letter message contains some special properties created by a client automatically.
   ```

##########
File path: site2/docs/concepts-messaging.md
##########
@@ -273,13 +273,33 @@ Consumer<byte[]> consumer = pulsarClient.newConsumer(Schema.BYTES)
                 .subscribe();
 ```
 
+Retry letter message contains some special property，automatically created by client.
+
+special property | Description
+:--------------------|:-----------
+`REAL_TOPIC` | The real topic name.
+`ORIGIN_MESSAGE_ID` | The origin message id, it will be crucial for message tracking.

Review comment:
       ```suggestion
   `ORIGIN_MESSAGE_ID` | The origin message ID. It is crucial for message tracking.
   ```
   - Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true. Details see https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp
   
   - Capitalize proper nouns correctly. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org