You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vladimir Ivanov (JIRA)" <ji...@apache.org> on 2007/02/16 13:45:05 UTC

[jira] Created: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

[classlib][testing] test case should be run only once when specified through the command line
---------------------------------------------------------------------------------------------

                 Key: HARMONY-3187
                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Vladimir Ivanov
            Priority: Minor
         Attachments: tc.patch

Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Resolved: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by Alexei Zakharov <al...@gmail.com>.
Aha, I see. Just was misled by the JIRA comment.

Thanks,

2007/3/23, Vladimir Ivanov <iv...@gmail.com>:
> No, you should use -Dtest.case for both cases.
>
>  thanks, Vladimir
>
> On 3/23/07, Alexei Zakharov <al...@gmail.com> wrote:
> > Stepan. Vladimir,
> >
> > Just to check. Did I understand correctly that now we should use
> > -Dtest.case for com.apache.harmony.MyTest notation and -Dconverted.tc
> > for com/apache/harmony/MyTest.java (i.e. if we like to copy-paste from
> > the exclude list)?
> >
> > Thanks,
> >
> > 2007/3/23, Stepan Mishura (JIRA) <ji...@apache.org>:
> > >
> > >      [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> > >
> > > Stepan Mishura resolved HARMONY-3187.
> > > -------------------------------------
> > >
> > >     Resolution: Fixed
> > >
> > > Thanks Vladimir -  the patch was applied to CLASSLIB at r521594.
> > > Please check that the patch was applied as you expected.
> > >
> > >
> > > > [classlib][testing] test case should be run only once when specified through the command line
> > > > ---------------------------------------------------------------------------------------------
> > > >
> > > >                 Key: HARMONY-3187
> > > >                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
> > > >             Project: Harmony
> > > >          Issue Type: Bug
> > > >          Components: Classlib
> > > >            Reporter: Vladimir Ivanov
> > > >         Assigned To: Stepan Mishura
> > > >            Priority: Minor
> > > >         Attachments: lang_management.patch, tc.patch, tcase.patch
> > > >
> > > >
> > > > Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > You can reply to this email to add a comment to the issue online.


-- 
Alexei Zakharov,
Intel ESSD

Re: [jira] Resolved: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by Vladimir Ivanov <iv...@gmail.com>.
No, you should use -Dtest.case for both cases.

 thanks, Vladimir

On 3/23/07, Alexei Zakharov <al...@gmail.com> wrote:
> Stepan. Vladimir,
>
> Just to check. Did I understand correctly that now we should use
> -Dtest.case for com.apache.harmony.MyTest notation and -Dconverted.tc
> for com/apache/harmony/MyTest.java (i.e. if we like to copy-paste from
> the exclude list)?
>
> Thanks,
>
> 2007/3/23, Stepan Mishura (JIRA) <ji...@apache.org>:
> >
> >      [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Stepan Mishura resolved HARMONY-3187.
> > -------------------------------------
> >
> >     Resolution: Fixed
> >
> > Thanks Vladimir -  the patch was applied to CLASSLIB at r521594.
> > Please check that the patch was applied as you expected.
> >
> >
> > > [classlib][testing] test case should be run only once when specified through the command line
> > > ---------------------------------------------------------------------------------------------
> > >
> > >                 Key: HARMONY-3187
> > >                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
> > >             Project: Harmony
> > >          Issue Type: Bug
> > >          Components: Classlib
> > >            Reporter: Vladimir Ivanov
> > >         Assigned To: Stepan Mishura
> > >            Priority: Minor
> > >         Attachments: lang_management.patch, tc.patch, tcase.patch
> > >
> > >
> > > Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
>
> --
> Alexei Zakharov,
> Intel ESSD
>

Re: [jira] Resolved: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by Alexei Zakharov <al...@gmail.com>.
Stepan. Vladimir,

Just to check. Did I understand correctly that now we should use
-Dtest.case for com.apache.harmony.MyTest notation and -Dconverted.tc
for com/apache/harmony/MyTest.java (i.e. if we like to copy-paste from
the exclude list)?

Thanks,

2007/3/23, Stepan Mishura (JIRA) <ji...@apache.org>:
>
>      [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Stepan Mishura resolved HARMONY-3187.
> -------------------------------------
>
>     Resolution: Fixed
>
> Thanks Vladimir -  the patch was applied to CLASSLIB at r521594.
> Please check that the patch was applied as you expected.
>
>
> > [classlib][testing] test case should be run only once when specified through the command line
> > ---------------------------------------------------------------------------------------------
> >
> >                 Key: HARMONY-3187
> >                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
> >             Project: Harmony
> >          Issue Type: Bug
> >          Components: Classlib
> >            Reporter: Vladimir Ivanov
> >         Assigned To: Stepan Mishura
> >            Priority: Minor
> >         Attachments: lang_management.patch, tc.patch, tcase.patch
> >
> >
> > Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

-- 
Alexei Zakharov,
Intel ESSD

[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stepan Mishura updated HARMONY-3187:
------------------------------------

    Attachment: lang_management.patch

Vladimir,

Is there any value in using "test.case" as a package+class name? A possible way to fix the issues is to pass it as dir+file name (see attachment lang_management.patch).

Thanks,
Stepan.

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stepan Mishura reassigned HARMONY-3187:
---------------------------------------

    Assignee: Stepan Mishura

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: tc.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474642 ] 

Vladimir Ivanov commented on HARMONY-3187:
------------------------------------------

The main value is no changes in user interface :) I agree that dir+file is easier in implementation. So we can discuss it on the dev@ and if everyone agrees then update interface.

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov updated HARMONY-3187:
-------------------------------------

    Attachment:     (was: tcase.patch)

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov updated HARMONY-3187:
-------------------------------------

    Attachment: tcase.patch

patch for other modules

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481103 ] 

Stepan Mishura commented on HARMONY-3187:
-----------------------------------------

Hi Vladimir,

I've applied modified patch fro LANG-MANAGMENT module at r518562. Let me know if my modifications work for you. If they are OK please go forward with fixing other modules.

Thanks,
Stepan.

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov updated HARMONY-3187:
-------------------------------------

    Attachment: tcase.patch

the correct variant for the record:
                 <fileset dir="${hy.accessibility.src.test.api}/java/common">
-                    <excludesfile name="${accessibility.exclude.file}" />
                 </fileset>  
is
                 <fileset dir="${hy.accessibility.src.test.api}/java/common">
                    <!-- if ${test.case}     -->
                    <include name="${converted.tc}" if="test.case" />
                    <!-- unless ${test.case} -->
                    <include name="**/*.java" unless="test.case" />
                    <excludesfile name="${accessibility.exclude.file}" unless="test.case"/>
                 </fileset>  
instead of
                 <fileset dir="${hy.accessibility.src.test.api}/java/common">
                    <!-- if ${test.case}     -->
                    <include name="${converted.tc}" if="test.case" />
                    <!-- unless ${test.case} -->
                    <excludesfile name="${accessibility.exclude.file}" unless="test.case"/>
                 </fileset>  

files for modules accessibility annotation applet  were updated. 

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482059 ] 

Stepan Mishura commented on HARMONY-3187:
-----------------------------------------

Vladimir, I've noticed that after applying the patch a total number of running tests is reduced by 27. 
Could you verify that the patch doesn't exclude additional tests?

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov closed HARMONY-3187.
------------------------------------


Thanks, patch was applied as expected.

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov updated HARMONY-3187:
-------------------------------------

    Attachment: tc.patch

patch for lang-management module.
If it is OK I'll prepare patches for other modules

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>            Priority: Minor
>         Attachments: tc.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov updated HARMONY-3187:
-------------------------------------

    Attachment:     (was: tcase.patch)

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stepan Mishura resolved HARMONY-3187.
-------------------------------------

    Resolution: Fixed

Thanks Vladimir -  the patch was applied to CLASSLIB at r521594.
Please check that the patch was applied as you expected.


> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Vladimir Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Ivanov updated HARMONY-3187:
-------------------------------------

    Attachment: tcase.patch

patch to support both notation.
Note the "Test.java" string used as marker to run conversion so to run TestCase'es that have different names use "-Dconverted.tc=<>" instead of  "-Dtest.case=<>"

 thanks, Vladimir

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch, tcase.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3187) [classlib][testing] test case should be run only once when specified through the command line

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474648 ] 

Stepan Mishura commented on HARMONY-3187:
-----------------------------------------

Link to dev-list:
http://mail-archives.apache.org/mod_mbox/harmony-dev/200702.mbox/%3c7273946b0702150256n4c723c7by11c387ca1e833e56@mail.gmail.com%3e

> [classlib][testing] test case should be run only once when specified through the command line
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3187
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3187
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Assigned To: Stepan Mishura
>            Priority: Minor
>         Attachments: lang_management.patch, tc.patch
>
>
> Any test case should be run only once when specified through the command line. Now it runs over all 4 possible tests-set (api, impl, ...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.