You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Tony Zhang (JIRA)" <ji...@apache.org> on 2019/06/18 23:53:00 UTC

[jira] [Commented] (SPARK-27815) do not leak SaveMode to file source v2

    [ https://issues.apache.org/jira/browse/SPARK-27815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867136#comment-16867136 ] 

Tony Zhang commented on SPARK-27815:
------------------------------------

[~cloud_fan] Hi Wenchen, do you think it is viable solution mentioned below? 

Create a new V2WriteCommand case class and its Exec named maybe _OverwriteByQueryId_ to replace WriteToDataSourceV2, which accepts a QueryId so that tests can pass.

Or should we keep WriteToDataSourceV2?

> do not leak SaveMode to file source v2
> --------------------------------------
>
>                 Key: SPARK-27815
>                 URL: https://issues.apache.org/jira/browse/SPARK-27815
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Wenchen Fan
>            Priority: Blocker
>
> Currently there is a hack in `DataFrameWriter`, which passes `SaveMode` to file source v2. This should be removed and file source v2 should not accept SaveMode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org