[GitHub] stevedlawrence commented on a change in pull request #150: Removed use of ThreadLocal for DFA Register Pool.

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #150: Removed use of ThreadLocal for DFA Register Pool.
URL: https://github.com/apache/incubator-daffodil/pull/150#discussion_r240999631
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
 ##########
 @@ -119,8 +122,7 @@ trait SetProcessorMixin {
  * which should be isolated to the alternative parser, and repParsers, i.e.,
  * places where points-of-uncertainty are handled.
  */
-abstract class ParseOrUnparseState protected (
-  protected var variableBox: VariableBox,
+abstract class ParseOrUnparseState protected (protected var variableBox: VariableBox,
   var diagnostics: List[Diagnostic],
 
 Review comment:
   Looks to just be indentation changes here? Is this the corret style we're supposed to use? I personally don't really like having the first parameter not on a new line if the others are on a new line, but dont' feel strongly about it. Just want to make sure we're consistent. Looks like this style of indentation was made throughout. Maybe some eclipse auto indentation setting were changed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services