You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by en...@apache.org on 2019/10/28 20:58:07 UTC
[sling-org-apache-sling-jcr-jackrabbit-accessmanager] branch master
updated: SLING-8809 ModifyAce request should return a meaningful error
message when an invalid principalId is submitted
This is an automated email from the ASF dual-hosted git repository.
enorman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-jackrabbit-accessmanager.git
The following commit(s) were added to refs/heads/master by this push:
new 64be7e5 SLING-8809 ModifyAce request should return a meaningful error message when an invalid principalId is submitted
64be7e5 is described below
commit 64be7e51a3504afb137544406de2926fc651bdf8
Author: Eric Norman <en...@apache.org>
AuthorDate: Mon Oct 28 13:57:58 2019 -0700
SLING-8809 ModifyAce request should return a meaningful error message
when an invalid principalId is submitted
---
.../sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
index deeb03d..f8f19a5 100644
--- a/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
+++ b/src/main/java/org/apache/sling/jcr/jackrabbit/accessmanager/post/ModifyAceServlet.java
@@ -266,6 +266,9 @@ public class ModifyAceServlet extends AbstractAccessPostServlet implements Modif
}
PrincipalManager principalManager = AccessControlUtil.getPrincipalManager(jcrSession);
Principal principal = principalManager.getPrincipal(principalId);
+ if (principal == null) {
+ throw new RepositoryException("Invalid principalId was submitted.");
+ }
if (resourcePath == null) {
throw new ResourceNotFoundException("Resource path was not supplied.");