[jira] [Commented] (SPARK-28096) Lazy val performance pitfall in Spark SQL LogicalPlans

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-28096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866995#comment-16866995 ] 

Apache Spark commented on SPARK-28096:
--------------------------------------

User 'yeshengm' has created a pull request for this issue:
https://github.com/apache/spark/pull/24866

> Lazy val performance pitfall in Spark SQL LogicalPlans
> ------------------------------------------------------
>
>                 Key: SPARK-28096
>                 URL: https://issues.apache.org/jira/browse/SPARK-28096
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Yesheng Ma
>            Priority: Major
>
> The original {{references}} and {{validConstraints}} implementations in a few QueryPlan and Expression classes are methods, which means unnecessary re-computation can happen at times. This PR resolves this problem by making these method lazy vals.
> We benchmarked this optimization on TPC-DS queries whose planning time is longer than 1s. In the benchmark, we warmed up the queries 5 iterations and then took the average of 10 runs. Results showed that this micro-optimization can improve the end-to-end planning time by 25%.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org