You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/03 03:57:11 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6756: [AIRFLOW-6198] Add types to core classes.

mik-laj commented on a change in pull request #6756: [AIRFLOW-6198] Add types to core classes.
URL: https://github.com/apache/airflow/pull/6756#discussion_r362701017
 
 

 ##########
 File path: airflow/cli/commands/dag_command.py
 ##########
 @@ -41,7 +41,7 @@ def _tabulate_dag_runs(dag_runs: List[DagRun], tablefmt="fancy_grid"):
             'Run ID': dag_run.run_id,
             'State': dag_run.state,
             'DAG ID': dag_run.dag_id,
-            'Execution date': dag_run.execution_date.isoformat(),
+            'Execution date': dag_run.execution_date.isoformat() if dag_run.execution_date else "",
 
 Review comment:
   ```suggestion
               'Execution date': dag_run.execution_date.isoformat() if dag_run.execution_date else None,
   ```
   JSON supports null type, so we can use it instead of empty text.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services