You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/05/27 18:20:38 UTC
[kudu-CR] Patch bison 3.0.4 and gnulib > 2.28
sdrreynolds+gh@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13446
Change subject: Patch bison 3.0.4 and gnulib > 2.28
......................................................................
Patch bison 3.0.4 and gnulib > 2.28
Summary:
Gnulib is terrible and makes life difficult. This problem is fixed in
later bison releases -- I have been unable to find a reference commit
to point to. Bison and glibc seem pretty tied at the hip and they
likely need to be tracked together in some manner.
KUDU-2770
Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/bison-fix-gnulib-2.28.patch
2 files changed, 35 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/13446/1
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sd...@gmail.com>
[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 )
Change subject: KUDU-2770: Upgrade bison to 3.0.5
......................................................................
Patch Set 3:
Thanks for the contribution!
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 01 Jul 2019 17:11:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13446 )
Change subject: KUDU-2770: Upgrade bison to 3.0.5
......................................................................
KUDU-2770: Upgrade bison to 3.0.5
Summary:
Bison 3.0.4 does not compile under glib 2.28, a fix for this was
introduced in
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4af4a4a71827c0bc5e0ec67af23edef4f15cee8e
This also removes the patch for Mac OS High Sierra as it is believed
to be no longer required
Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Reviewed-on: http://gerrit.cloudera.org:8080/13446
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/bison-fix-high-sierra-compilation-issue.patch
M thirdparty/vars.sh
3 files changed, 4 insertions(+), 22 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 )
Change subject: KUDU-2770: Upgrade bison to 3.0.5
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13446/2/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/13446/2/thirdparty/download-thirdparty.sh@415
PS2, Line 415: "http://ftpmirror.gnu.org/bison/"
I uploaded bison-3.0.5.tar.gz to our S3 bucket, so you should be able to remove this and download it from the Cloudfront cache just like any other dependency.
http://gerrit.cloudera.org:8080/#/c/13446/2/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/13446/2/thirdparty/vars.sh@a246
PS2, Line 246:
Nit: revert this?
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 02 Jun 2019 21:27:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] Patch bison 3.0.4 and gnulib > 2.28
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 )
Change subject: Patch bison 3.0.4 and gnulib > 2.28
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13446/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13446/1//COMMIT_MSG@15
PS1, Line 15: KUDU-2770
move to title
http://gerrit.cloudera.org:8080/#/c/13446/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/13446/1/thirdparty/download-thirdparty.sh@410
PS1, Line 410: BISON_PATCHLEVEL=1
same comment as the other patches -- increment this
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 29 May 2019 04:20:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 )
Change subject: KUDU-2770: Upgrade bison to 3.0.5
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 01 Jul 2019 17:10:52 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5
Posted by "Scott Reynolds (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13446
to look at the new patch set (#3).
Change subject: KUDU-2770: Upgrade bison to 3.0.5
......................................................................
KUDU-2770: Upgrade bison to 3.0.5
Summary:
Bison 3.0.4 does not compile under glib 2.28, a fix for this was
introduced in
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4af4a4a71827c0bc5e0ec67af23edef4f15cee8e
This also removes the patch for Mac OS High Sierra as it is believed
to be no longer required
Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/bison-fix-high-sierra-compilation-issue.patch
M thirdparty/vars.sh
3 files changed, 4 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/13446/3
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Patch bison 3.0.4 and gnulib > 2.28
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 )
Change subject: Patch bison 3.0.4 and gnulib > 2.28
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13446/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13446/1//COMMIT_MSG@10
PS1, Line 10: This problem is fixed in
: later bison releases
Yeah. We should definitely merge this now to fix the breakage on new systems, but would you also be open to upgrading our bison dependency to the latest?
http://gerrit.cloudera.org:8080/#/c/13446/1/thirdparty/patches/bison-fix-gnulib-2.28.patch
File thirdparty/patches/bison-fix-gnulib-2.28.patch:
PS1:
This looks like http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4af4a4a71827c0bc5e0ec67af23edef4f15cee8e, but don't you want to backport that patch in its entirety? It'd certainly make it easier to correlate with upstream.
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 29 May 2019 18:25:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5
Posted by "Scott Reynolds (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13446
to look at the new patch set (#2).
Change subject: KUDU-2770: Upgrade bison to 3.0.5
......................................................................
KUDU-2770: Upgrade bison to 3.0.5
Summary:
Bison 3.0.4 does not compile under glib 2.28, a fix for this was
introduced in
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4af4a4a71827c0bc5e0ec67af23edef4f15cee8e
This also removes the patch for Mac OS High Sierra as it is believed
to be no longer required
Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/bison-fix-high-sierra-compilation-issue.patch
M thirdparty/vars.sh
3 files changed, 5 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/13446/2
--
To view, visit http://gerrit.cloudera.org:8080/13446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I892af2d85bb481248715ba971a4439bc66ce4c90
Gerrit-Change-Number: 13446
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>