[GitHub] [doris] morrySnow commented on a diff in pull request #20967: [Enhancement](Nereids)replace some nullable field to Optional

["morrySnow (via GitHub)" <gi...@apache.org>]

morrySnow commented on code in PR #20967:
URL: https://github.com/apache/doris/pull/20967#discussion_r1234190150


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundOlapTableSink.java:
##########
@@ -40,34 +39,34 @@
  */
 public class UnboundOlapTableSink<CHILD_TYPE extends Plan> extends LogicalUnary<CHILD_TYPE> implements Unbound {
     private final List<String> nameParts;
-    private final List<String> colNames;
-    private final List<String> hints;
-    private final List<String> partitions;
+    private final Optional<List<String>> colNames;

Review Comment:
   why not use emptylist directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org