You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/22 03:26:53 UTC
[GitHub] [pulsar] michaeljmarshall commented on issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
michaeljmarshall commented on issue #17595:
URL: https://github.com/apache/pulsar/issues/17595#issuecomment-1254473931
> I do expect that if no entry filter has been used by the dispatcher, the `filterProcessedMsgCount` and `filterAcceptedMsgCount` metrics should not be increased.
I am a bit late on this issue, but one comment is that the naming on that metric is ambiguous and could have been meaningful in the previous design. For example, we filter out certain entries that are system messages even when there are not entry filters. Perhaps we should make sure not to count system messages in the `filterProcessedMsgCount` counter to prevent them from skewing the numbers for the filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org