[GitHub] valdar opened a new pull request #389: Fixed AddDependency in integration_type_support.go to handle default …

[GitBox <gi...@apache.org>]

valdar opened a new pull request #389: Fixed AddDependency in integration_type_support.go to handle default …
URL: https://github.com/apache/camel-k/pull/389
 
 
   …case instead of discarding.
   
   there was a problem handling `--runtime xxx` dependencies that got discarded:
   ```if o.Runtime != "" {
           integration.Spec.AddDependency("runtime:" + o.Runtime)
       }```
   and
   ```func (is *IntegrationSpec) AddDependency(dependency string) {
       switch {
       case strings.HasPrefix(dependency, "mvn:"):
           util.StringSliceUniqueAdd(&is.Dependencies, dependency)
       case strings.HasPrefix(dependency, "file:"):
           util.StringSliceUniqueAdd(&is.Dependencies, dependency)
       case strings.HasPrefix(dependency, "camel-"):
           util.StringSliceUniqueAdd(&is.Dependencies, "camel:"+strings.TrimPrefix(dependency, "camel-"))
       }
   }```
   were not cooping that well together resulting in any `--runtime` option to be discarded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services