You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/14 13:56:39 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2533: Make the number of queue/signal used by irq handler configurable

patacongo commented on a change in pull request #2533:
URL: https://github.com/apache/incubator-nuttx/pull/2533#discussion_r542402116



##########
File path: sched/mqueue/mqueue.h
##########
@@ -53,12 +53,6 @@
 
 #define NUM_MSG_DESCRIPTORS  4
 
-/* This defines the number of messages to set aside for exclusive use by
- * interrupt handlers
- */
-
-#define NUM_INTERRUPT_MSGS   8

Review comment:
       > It could be a good idea to include a fail-safe protection:
   > 
   > #if !defined(CONFIG_PREALLOC_MQ_IRQ_MSGS)
   > #define CONFIG_PREALLOC_MQ_IRQ_MSGS 8
   > #endif
   
   We used to do these kinds of paranoid checks back in the old days when we hand edited config files.  This practice is not done anymore.  We trust the Kconfig files now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org