You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/03 15:09:38 UTC
[GitHub] [flink] NickBurkard opened a new pull request #14544: [DRAFT] Drop Scala 2.11 support
NickBurkard opened a new pull request #14544:
URL: https://github.com/apache/flink/pull/14544
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Begin the transition to supporting Scala 2.13 in Flink by dropping Scala 2.11 support.
I purposely left out upgrading the Scala 2.12 version to latest (2.12.12) to limit this PR's changes.
## Brief change log
- Flink defaults to compiling with Scala 2.12.
- Docs reference Scala 2.12 as the default build version.
- Scala 2.11 is no longer supported as a compile target.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: don't know
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: don't know
- The S3 file system connector: don't know
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-846091998
I think the community is moving towards minimizing the usage of Scala in Flink:
https://issues.apache.org/jira/browse/FLINK-13414
The current blocker for this particular PR is that flink's scala shell requires using the compiler flag `-Yrepl-class-based` with 2.12, but needs to be refactored a bit more to support it, since it break's Flink's requirements for not nesting classes within other classes for serialization requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929547478
I'm under the impression that from a Flink perspective, a user should update its POM file to point to Flink's 2.12 version instead of 2.11.
Flink's Scala APIs don't differ between 2.11 and 2.12.
The only thing I do not know is if savepoints made with a Flink job using Scala 2.11 can be restored if the job is changed to a Scala 2.12 job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r718589174
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -69,6 +69,11 @@ under the License.
<artifactId>scala-compiler</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.scala-lang.modules</groupId>
+ <artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
Review comment:
please move this down into the `<dependencyManagement>` section; that way we don't change the structure of the dependency tree, but just modify the version. (i.e., the dependency tree still shows where this dependency came from)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551897178
##########
File path: pom.xml
##########
@@ -822,53 +822,6 @@ under the License.
</dependencyManagement>
<profiles>
- <profile>
- <id>scala-2.11</id>
- <properties>
- <scala.version>2.11.12</scala.version>
- <scala.binary.version>2.11</scala.binary.version>
- </properties>
- <activation>
- <property>
- <name>!scala-2.12</name>
- </property>
- </activation>
- <!-- Scala Shell doesn't currently work with Scala 2.12 so only include
- when building for Scala 2.11. -->
- <modules>
- <module>flink-scala-shell</module>
- </modules>
- <build>
- <plugins>
- <!-- make sure we don't have any _2.10 or _2.12 dependencies when building
- for Scala 2.11 -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
- <id>enforce-versions</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <configuration>
- <rules>
- <bannedDependencies>
- <excludes combine.children="append">
- <exclude>*:*_2.12</exclude>
Review comment:
Agreed, I left the corresponding version for the 2.12 profile intact, i.e. it excludes 2.10 and 2.11 artifacts on build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929279774
@MartijnVisser @NickBurkard Do you already have some form of migration guide for 2.11 users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] erwan commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
erwan commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-779047753
I'm not sure what's the contract around release numbers, but maybe we can remove 2.11 for Flink 1.13 but keep it on the 1.12 branch?
So many libraries dropped 2.11 support already, I imagine users still on 2.11 aren't upgrading their dependencies anyway so they shouldn't be surprised if they can't upgrade Flink either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-927836453
@NickBurkard I think the CI failed due to https://github.com/apache/flink/pull/17359 so it probably needs another rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a95d3c54d273d33657ffb446e47878f87471069c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-927847942
Thanks for the PR @NickBurkard
I still saw some references to 2.11
* https://github.com/apache/flink/blame/master/docs/README.md#L113
* https://github.com/apache/flink/blob/master/docs/config.toml#L55
* docs/content.zh/docs/deployment/resource-providers/standalone/docker.md
* docs/content.zh/docs/dev/datastream/project-configuration.md
* docs/content/docs/deployment/resource-providers/standalone/docker.md
* docs/content/docs/dev/datastream/project-configuration.md
* flink-dist/src/main/resources/META-INF/NOTICE
* flink-table/flink-table-planner/src/main/resources/META-INF/NOTICE
I'm also pinging @zentol if he can have a look
There are also a couple of NOTICE files which I'm not sure if they would need to be updated:
* flink-dist/src/main/resources/META-INF/NOTICE
Because `com.twitter:chill_2.11:0.7.6` could/should be `com.twitter:chill_2.12:0.7.6`
* flink-table/flink-table-planner/src/main/resources/META-INF/NOTICE
Because `org.scala-lang.modules:scala-parser-combinators_2.11:1.1.1` could/should become `org.scala-lang.modules:scala-parser-combinators_2.12:1.1.1` and `org.scala-lang.modules:scala-xml_2.12:1.0.5 could/should become `org.scala-lang.modules:scala-xml_2.12:1.0.5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930032978
@MartijnVisser Of course, but I would like to have those ready when I close the ticket such that I can document them in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-928956978
I found two more minor references:
https://github.com/apache/flink/blob/master/flink-end-to-end-tests/test-scripts/kafka-common.sh#L55
Also the flag at https://github.com/apache/flink/blob/master/flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala#L42
can be removed and the condition that uses it at https://github.com/apache/flink/blob/master/flink-scala/src/main/scala/org/apache/flink/api/scala/ClosureCleaner.scala#L177-L179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929111051
Thanks for the feedback @MartijnVisser & @zentol. I addressed each point, although I was hesitant to start removing methods from `JavaScalaConversionUtil` as its comment suggested, since its methods were used by many different classes. I instead opted to simplify the methods since Flink always uses at least Scala 2.12. If there's any other changes that need to be made let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
}, {
"hash" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631",
"triggerID" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7982b346fd3562a11815cd7e94845e1e5c4cb02b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r717315877
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/main/java/org/apache/flink/tests/util/kafka/LocalStandaloneKafkaResource.java
##########
@@ -89,7 +89,7 @@
private static String getKafkaDownloadUrl(final String kafkaVersion) {
return String.format(
- "https://archive.apache.org/dist/kafka/%s/kafka_2.11-%s.tgz",
+ "https://archive.apache.org/dist/kafka/%s/kafka_2.12-%s.tgz",
Review comment:
technically this doesn't require changes because it's an entirely separate application
##########
File path: pom.xml
##########
@@ -877,7 +830,7 @@ under the License.
</properties>
<activation>
<property>
- <name>scala-2.12</name>
+ <name>!scala-2.11</name>
Review comment:
maybe use some magic property name that is unlikely to be used because there could be scripts that accidentally set `-Dscala-2.11`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on a change in pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551018720
##########
File path: pom.xml
##########
@@ -822,53 +822,6 @@ under the License.
</dependencyManagement>
<profiles>
- <profile>
- <id>scala-2.11</id>
- <properties>
- <scala.version>2.11.12</scala.version>
- <scala.binary.version>2.11</scala.binary.version>
- </properties>
- <activation>
- <property>
- <name>!scala-2.12</name>
- </property>
- </activation>
- <!-- Scala Shell doesn't currently work with Scala 2.12 so only include
- when building for Scala 2.11. -->
- <modules>
- <module>flink-scala-shell</module>
- </modules>
Review comment:
I noticed that `flink-scala-shell` does not support Scala 2.12 yet. I just removed the conditional compilation, the module remains. It looks like https://github.com/apache/flink/pull/11895 addresses this but is still in-progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-778694023
Hey sorry for the delay in response! I did check out that email thread @aljoscha. I do think dropping Scala 2.11 is the right first step to make to the path of supporting 2.13. Ultimately 2.11 is holding back library upgrades that will be required to make the jump to 2.13, many of which I don't think even cross-build from 2.11, 2.12 and 2.13. Perhaps we can consider separating these Scala-specific changes to a separate tag, so that it doesn't impact users who depend on releases?
As for the scala-shell issue, I can take a look into the PR and see if I can get it working, since I saw it's still stuck to 2.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on a change in pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551017832
##########
File path: docs/flinkDev/building.md
##########
@@ -128,9 +128,9 @@ mvn clean install
Flink has APIs, libraries, and runtime modules written in [Scala](http://scala-lang.org). Users of the Scala API and libraries may have to match the Scala version of Flink with the Scala version of their projects (because Scala is not strictly backwards compatible).
-Since version 1.7 Flink builds with Scala version 2.11 (default) and 2.12.
+Since version 1.13 Flink builds with Scala version 2.12 (default).
Review comment:
Can be changed to whichever version this gets released with. 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d03f03be594cbe205f649142c24d64cb99734479 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r718431519
##########
File path: flink-dist/src/main/resources/META-INF/NOTICE
##########
@@ -29,11 +29,11 @@ See bundled license files for details.
The following dependencies all share the same BSD license which you find under licenses/LICENSE.scala.
-- org.scala-lang:scala-compiler:2.11.12
-- org.scala-lang:scala-library:2.11.12
-- org.scala-lang:scala-reflect:2.11.12
-- org.scala-lang.modules:scala-parser-combinators_2.11:1.1.1
-- org.scala-lang.modules:scala-xml_2.11:1.0.5
+- org.scala-lang:scala-compiler:2.12.7
+- org.scala-lang:scala-library:2.12.7
+- org.scala-lang:scala-reflect:2.12.7
+- org.scala-lang.modules:scala-parser-combinators_2.12:1.1.1
+- org.scala-lang.modules:scala-xml_2.12:1.0.5
Review comment:
```suggestion
- org.scala-lang.modules:scala-xml_2.12:1.0.6
```
combinators is no longer a transtive dependency, and the correct scala-xml version is 1.0.6.
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -69,6 +69,11 @@ under the License.
<artifactId>scala-compiler</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.scala-lang.modules</groupId>
+ <artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
Review comment:
please move this down into the `<dependencyManagement>` section; that way we don't change the structure of the dependency tree, but just modify the version. (i.e., the dependency tree still shows where this dependency came from)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930028688
@zentol My proposal would be to add migration remarks in the release notes, are you OK with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a95d3c54d273d33657ffb446e47878f87471069c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576)
* 7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a95d3c54d273d33657ffb446e47878f87471069c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753631803
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b1fe24bab5f3a3588e594ed41932c41cc87bd069 (Thu Sep 23 18:53:12 UTC 2021)
**Warnings:**
* **6 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8176225bb34991546b0830c1c427132864defdc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r717315877
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/main/java/org/apache/flink/tests/util/kafka/LocalStandaloneKafkaResource.java
##########
@@ -89,7 +89,7 @@
private static String getKafkaDownloadUrl(final String kafkaVersion) {
return String.format(
- "https://archive.apache.org/dist/kafka/%s/kafka_2.11-%s.tgz",
+ "https://archive.apache.org/dist/kafka/%s/kafka_2.12-%s.tgz",
Review comment:
technically this doesn't require changes because it's an entirely separate application
##########
File path: pom.xml
##########
@@ -877,7 +830,7 @@ under the License.
</properties>
<activation>
<property>
- <name>scala-2.12</name>
+ <name>!scala-2.11</name>
Review comment:
maybe use some magic property name that is unlikely to be used because there could be scripts that accidentally set `-Dscala-2.11`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
}, {
"hash" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631",
"triggerID" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 949caed0d8c056398ffb492c8d2ed39a1704f92d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625)
* 7982b346fd3562a11815cd7e94845e1e5c4cb02b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929111051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r718591390
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -69,6 +69,11 @@ under the License.
<artifactId>scala-compiler</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.scala-lang.modules</groupId>
+ <artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
Review comment:
>
>
> please move this down into the `<dependencyManagement>` section; that way we don't change the structure of the dependency tree, but just modify the version. (i.e., the dependency tree still shows where this dependency came from)
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318)
* b1fe24bab5f3a3588e594ed41932c41cc87bd069 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-778694023
Hey sorry for the delay in response! I did check out that email thread @aljoscha. I do think dropping Scala 2.11 is the right first step in the path to supporting 2.13. Ultimately 2.11 is holding back library upgrades that will be required to make the jump to 2.13, many of which I don't think even cross-build from 2.11, 2.12 and 2.13. Perhaps we can consider separating these Scala-specific changes to a separate tag, so that it doesn't impact users who depend on releases?
As for the scala-shell issue, I can take a look into the PR and see if I can get it working, since I saw it's still stuck to 2.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930829380
I have reverted 29ecd0af6aa02f791c3da78401f3f568e1ea51e8 because it on the one hand should be unnecessary (because it's a separate application) and more importantly because there is no 2.12 artifact for 5.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r718591390
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -69,6 +69,11 @@ under the License.
<artifactId>scala-compiler</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.scala-lang.modules</groupId>
+ <artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
Review comment:
>
>
> please move this down into the `<dependencyManagement>` section; that way we don't change the structure of the dependency tree, but just modify the version. (i.e., the dependency tree still shows where this dependency came from)
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-928956978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929130616
> The scala 2.12 profile in flink-end-to-end-tests, flink-avro can be removed.
This point was not addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540)
* 4edc761643720dca6b8be2089bd60f66be90f3b1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4edc761643720dca6b8be2089bd60f66be90f3b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575)
* b8176225bb34991546b0830c1c427132864defdc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930154870
I made the remaining changes @zentol, let me know if there's anything else. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551832278
##########
File path: pom.xml
##########
@@ -822,53 +822,6 @@ under the License.
</dependencyManagement>
<profiles>
- <profile>
- <id>scala-2.11</id>
- <properties>
- <scala.version>2.11.12</scala.version>
- <scala.binary.version>2.11</scala.binary.version>
- </properties>
- <activation>
- <property>
- <name>!scala-2.12</name>
- </property>
- </activation>
- <!-- Scala Shell doesn't currently work with Scala 2.12 so only include
- when building for Scala 2.11. -->
- <modules>
- <module>flink-scala-shell</module>
- </modules>
- <build>
- <plugins>
- <!-- make sure we don't have any _2.10 or _2.12 dependencies when building
- for Scala 2.11 -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
- <id>enforce-versions</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <configuration>
- <rules>
- <bannedDependencies>
- <excludes combine.children="append">
- <exclude>*:*_2.12</exclude>
Review comment:
It might make sense to keep this for the future, when we add Scala 2.13. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a95d3c54d273d33657ffb446e47878f87471069c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576)
* 7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-926845102
@MartijnVisser yep it should be unblocked now! I rebased with `master`, will let the CI suite run again to verify changes are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551970820
##########
File path: pom.xml
##########
@@ -822,53 +822,6 @@ under the License.
</dependencyManagement>
<profiles>
- <profile>
- <id>scala-2.11</id>
- <properties>
- <scala.version>2.11.12</scala.version>
- <scala.binary.version>2.11</scala.binary.version>
- </properties>
- <activation>
- <property>
- <name>!scala-2.12</name>
- </property>
- </activation>
- <!-- Scala Shell doesn't currently work with Scala 2.12 so only include
- when building for Scala 2.11. -->
- <modules>
- <module>flink-scala-shell</module>
- </modules>
- <build>
- <plugins>
- <!-- make sure we don't have any _2.10 or _2.12 dependencies when building
- for Scala 2.11 -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
- <id>enforce-versions</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <configuration>
- <rules>
- <bannedDependencies>
- <excludes combine.children="append">
- <exclude>*:*_2.12</exclude>
Review comment:
Ah yes, I missed that one. Sorry 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] virusdave commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
virusdave commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-846071503
Any updates on this? 2.11 isn't getting any newer, and lack of 2.13 support is really holding us back. If this is really a blocker to that, how can I help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on a change in pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r551017949
##########
File path: pom.xml
##########
@@ -877,7 +830,7 @@ under the License.
</properties>
<activation>
<property>
- <name>scala-2.12</name>
+ <name>!scala-2.11</name>
Review comment:
Even if a user does not specify `-Dscala-2.12`, the 2.12 profile will trigger. I wanted to avoid using `activeByDefault`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14544:
URL: https://github.com/apache/flink/pull/14544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8176225bb34991546b0830c1c427132864defdc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583)
* 949caed0d8c056398ffb492c8d2ed39a1704f92d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1fe24bab5f3a3588e594ed41932c41cc87bd069 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445)
* d03f03be594cbe205f649142c24d64cb99734479 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d03f03be594cbe205f649142c24d64cb99734479 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488)
* c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-927912709
Thanks for the help with the remaining references @MartijnVisser! I rebased again and pushed up the requested changes, plus a few other 2.11 references I found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930032978
@MartijnVisser Of course, but I would like to have those ready when I close the ticket such that I can document them in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929130616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929207858
>
>
> > The scala 2.12 profile in flink-end-to-end-tests, flink-avro can be removed.
>
> This point was not addressed.
Ah you're right, I just pushed changes to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-929357246
>
>
> @MartijnVisser @NickBurkard Do you already have some form of migration guide for 2.11 users?
The main thing I would recommend is for users building Scala applications with sbt to properly add dependencies based on their Scala version, that way they don't end up with projects using the wrong dependencies. Scala 2.x versions are binary incompatible with one another.
```scala
val flinkVersion = "1.13.2"
lazy val myProject = project
.in(file("example-app"))
.settings(
scalaVersion := "2.12.15",
libraryDependencies ++= Seq(
// be sure to use `%%`, it uses the dependency based on Scala version.
"org.apache.flink" %% "flink-streaming-scala" % flinkVersion % Provided,
// other dependencies go here
)
)
```
If this isn't done, or if a 2.12 application is deployed to a Flink cluster running Scala 2.11, a runtime error will occur about a missing `Product` class:
https://stackoverflow.com/questions/42498035/java-lang-noclassdeffounderror-scala-productclass
I can add some of these notes to a separate doc in the repo if that sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930040850
@zentol I've updated the release notes in https://issues.apache.org/jira/browse/FLINK-20845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NickBurkard commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
NickBurkard commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930154870
I made the remaining changes @zentol, let me know if there's anything else. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1fe24bab5f3a3588e594ed41932c41cc87bd069 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445)
* d03f03be594cbe205f649142c24d64cb99734479 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-926509165
@NickBurkard Thanks to your work for dropping the Scala Shell via https://github.com/apache/flink/pull/17340, does this now also unblock you to complete this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-931196086
Thanks again for the contribution @NickBurkard and many thanks for the review & merging it @zentol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a95d3c54d273d33657ffb446e47878f87471069c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-758584167
@NickBurkard Did you have a chance to check out https://lists.apache.org/thread.html/ra817c5b54e3de48d80e5b4e0ae67941d387ee25cf9779f5ae37d0486%40%3Cdev.flink.apache.org%3E?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r718431519
##########
File path: flink-dist/src/main/resources/META-INF/NOTICE
##########
@@ -29,11 +29,11 @@ See bundled license files for details.
The following dependencies all share the same BSD license which you find under licenses/LICENSE.scala.
-- org.scala-lang:scala-compiler:2.11.12
-- org.scala-lang:scala-library:2.11.12
-- org.scala-lang:scala-reflect:2.11.12
-- org.scala-lang.modules:scala-parser-combinators_2.11:1.1.1
-- org.scala-lang.modules:scala-xml_2.11:1.0.5
+- org.scala-lang:scala-compiler:2.12.7
+- org.scala-lang:scala-library:2.12.7
+- org.scala-lang:scala-reflect:2.12.7
+- org.scala-lang.modules:scala-parser-combinators_2.12:1.1.1
+- org.scala-lang.modules:scala-xml_2.12:1.0.5
Review comment:
```suggestion
- org.scala-lang.modules:scala-xml_2.12:1.0.6
```
combinators is no longer a transtive dependency, and the correct scala-xml version is 1.0.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8176225bb34991546b0830c1c427132864defdc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583)
* 949caed0d8c056398ffb492c8d2ed39a1704f92d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
}, {
"hash" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8176225bb34991546b0830c1c427132864defdc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583)
* 949caed0d8c056398ffb492c8d2ed39a1704f92d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625)
* 7982b346fd3562a11815cd7e94845e1e5c4cb02b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
}, {
"hash" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631",
"triggerID" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"triggerType" : "PUSH"
}, {
"hash" : "31bb1e9b021c3f20b588f28429dccf454a90175e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "31bb1e9b021c3f20b588f28429dccf454a90175e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7982b346fd3562a11815cd7e94845e1e5c4cb02b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631)
* 31bb1e9b021c3f20b588f28429dccf454a90175e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
}, {
"hash" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631",
"triggerID" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8176225bb34991546b0830c1c427132864defdc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583)
* 949caed0d8c056398ffb492c8d2ed39a1704f92d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625)
* 7982b346fd3562a11815cd7e94845e1e5c4cb02b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4edc761643720dca6b8be2089bd60f66be90f3b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-930028688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
}, {
"hash" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24575",
"triggerID" : "4edc761643720dca6b8be2089bd60f66be90f3b1",
"triggerType" : "PUSH"
}, {
"hash" : "b8176225bb34991546b0830c1c427132864defdc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24583",
"triggerID" : "b8176225bb34991546b0830c1c427132864defdc",
"triggerType" : "PUSH"
}, {
"hash" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24625",
"triggerID" : "949caed0d8c056398ffb492c8d2ed39a1704f92d",
"triggerType" : "PUSH"
}, {
"hash" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631",
"triggerID" : "7982b346fd3562a11815cd7e94845e1e5c4cb02b",
"triggerType" : "PUSH"
}, {
"hash" : "31bb1e9b021c3f20b588f28429dccf454a90175e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24647",
"triggerID" : "31bb1e9b021c3f20b588f28429dccf454a90175e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7982b346fd3562a11815cd7e94845e1e5c4cb02b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24631)
* 31bb1e9b021c3f20b588f28429dccf454a90175e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24647)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318)
* b1fe24bab5f3a3588e594ed41932c41cc87bd069 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-754690732
Overall, the changes look good to me. However, there is still the question of whether we can do this change. I wrote a new mail to a previous discussion thread: https://lists.apache.org/thread.html/ra817c5b54e3de48d80e5b4e0ae67941d387ee25cf9779f5ae37d0486%40%3Cdev.flink.apache.org%3E. Maybe you also want to chime in there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14544: [DRAFT] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753631803
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a95d3c54d273d33657ffb446e47878f87471069c (Sun Jan 03 15:12:26 UTC 2021)
**Warnings:**
* **6 pom.xml files were touched**: Check for build and licensing issues.
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b1fe24bab5f3a3588e594ed41932c41cc87bd069 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-927847942
Thanks for the PR @NickBurkard
I still saw some references to 2.11
* https://github.com/apache/flink/blame/master/docs/README.md#L113
* https://github.com/apache/flink/blob/master/docs/config.toml#L55
* docs/content.zh/docs/deployment/resource-providers/standalone/docker.md
* docs/content.zh/docs/dev/datastream/project-configuration.md
* docs/content/docs/deployment/resource-providers/standalone/docker.md
* docs/content/docs/dev/datastream/project-configuration.md
* flink-dist/src/main/resources/META-INF/NOTICE
* flink-table/flink-table-planner/src/main/resources/META-INF/NOTICE
I'm also pinging @zentol if he can have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14544: [FLINK-20845] Drop Scala 2.11 support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14544:
URL: https://github.com/apache/flink/pull/14544#issuecomment-753633967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95d3c54d273d33657ffb446e47878f87471069c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11576",
"triggerID" : "a95d3c54d273d33657ffb446e47878f87471069c",
"triggerType" : "PUSH"
}, {
"hash" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13318",
"triggerID" : "7b92671c3ecb252643f1b27f9a9d12c8db1f0ccf",
"triggerType" : "PUSH"
}, {
"hash" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21445",
"triggerID" : "b1fe24bab5f3a3588e594ed41932c41cc87bd069",
"triggerType" : "PUSH"
}, {
"hash" : "d03f03be594cbe205f649142c24d64cb99734479",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488",
"triggerID" : "d03f03be594cbe205f649142c24d64cb99734479",
"triggerType" : "PUSH"
}, {
"hash" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d03f03be594cbe205f649142c24d64cb99734479 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24488)
* c7865562890ec8e1b41e83dbb5b2463ff5bbf9c8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org