You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Cédric Champeau <ce...@gmail.com> on 2017/09/29 07:15:39 UTC
Re: [1/2] groovy git commit: Turn off warnings from Java9: illegal
reflective access
I don't think it's a good idea. We have warnings because we do illegal
reflective access. We should fix that, instead of opening the world.
2017-09-29 4:46 GMT+02:00 <su...@apache.org>:
> Repository: groovy
> Updated Branches:
> refs/heads/GROOVY_2_6_X b1582c0d3 -> edd97ea9c
>
>
> Turn off warnings from Java9: illegal reflective access
>
> (cherry picked from commit 92bd96f)
>
>
> Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
> Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/602ce052
> Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/602ce052
> Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/602ce052
>
> Branch: refs/heads/GROOVY_2_6_X
> Commit: 602ce0520e22d2d373ce9248cccdccf324f61467
> Parents: b1582c0
> Author: sunlan <su...@apache.org>
> Authored: Fri Sep 29 10:34:12 2017 +0800
> Committer: sunlan <su...@apache.org>
> Committed: Fri Sep 29 10:46:25 2017 +0800
>
> ----------------------------------------------------------------------
> src/bin/startGroovy | 1 +
> src/bin/startGroovy.bat | 1 +
> 2 files changed, 2 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/groovy/blob/
> 602ce052/src/bin/startGroovy
> ----------------------------------------------------------------------
> diff --git a/src/bin/startGroovy b/src/bin/startGroovy
> index 155df15..dd3eb14 100644
> --- a/src/bin/startGroovy
> +++ b/src/bin/startGroovy
> @@ -282,6 +282,7 @@ startGroovy ( ) {
> if [ "$JAVA_VERSION" \> "1.8.0" ]; then
> ADD_MODULES_OPT="--add-modules"
> [ "${JAVA_OPTS#*$ADD_MODULES_OPT}" = "$JAVA_OPTS" ] &&
> JAVA_OPTS="$JAVA_OPTS $ADD_MODULES_OPT ALL-SYSTEM"
> + JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.io=ALL-UNNAMED
> --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.annotation=ALL-UNNAMED
> --add-opens=java.base/java.lang.invoke=ALL-UNNAMED
> --add-opens=java.base/java.lang.module=ALL-UNNAMED
> --add-opens=java.base/java.lang.ref=ALL-UNNAMED
> --add-opens=java.base/java.lang.reflect=ALL-UNNAMED
> --add-opens=java.base/java.math=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED
> --add-opens=java.base/java.net.spi=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED
> --add-opens=java.base/java.nio.channels=ALL-UNNAMED
> --add-opens=java.base/java.nio.channels.spi=ALL-UNNAMED
> --add-opens=java.base/java.nio.charset=ALL-UNNAMED
> --add-opens=java.base/java.nio.charset.spi=ALL-UNNAMED
> --add-opens=java.base/java.nio.file=ALL-UNNAMED
> --add-opens=java.base/java.nio.file.attribute=ALL-UNNAMED
> --add-opens=java.base/java.nio.file.spi=ALL-UNNAMED
> --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/
> java.se
> curity.acl=ALL-UNNAMED --add-opens=java.base/java.security.cert=ALL-UNNAMED
> --add-opens=java.base/java.security.interfaces=ALL-UNNAMED
> --add-opens=java.base/java.security.spec=ALL-UNNAMED
> --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.base/java.text.spi=ALL-UNNAMED
> --add-opens=java.base/java.time=ALL-UNNAMED --add-opens=java.base/java.time.chrono=ALL-UNNAMED
> --add-opens=java.base/java.time.format=ALL-UNNAMED
> --add-opens=java.base/java.time.temporal=ALL-UNNAMED
> --add-opens=java.base/java.time.zone=ALL-UNNAMED
> --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED
> --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
> --add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED
> --add-opens=java.base/java.util.function=ALL-UNNAMED
> --add-opens=java.base/java.util.jar=ALL-UNNAMED
> --add-opens=java.base/java.util.regex=ALL-UNNAMED
> --add-opens=java.base/java.util.spi=ALL-UNNAMED
> --add-opens=java.base/java.util.stream=ALL-UNNAM
> ED --add-opens=java.base/java.util.zip=ALL-UNNAMED
> --add-opens=java.datatransfer/java.awt.datatransfer=ALL-UNNAMED
> --add-opens=java.desktop/java.applet=ALL-UNNAMED
> --add-opens=java.desktop/java.awt=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.color=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.desktop=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.dnd=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.dnd.peer=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.event=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.font=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.geom=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.im=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.im.spi=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.image=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.image.renderable=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.peer=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.print=ALL-UNNAMED
> --add-opens=java.desktop/java.beans=ALL-UNNAMED
> --add-opens=java.desktop/java.beans.beancontext=ALL-UN
> NAMED --add-opens=java.instrument/java.lang.instrument=ALL-UNNAMED
> --add-opens=java.logging/java.util.logging=ALL-UNNAMED
> --add-opens=java.management/java.lang.management=ALL-UNNAMED
> --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi=ALL-UNNAMED --add-opens=java.rmi/java.rmi.activation=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi.dgc=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi.registry=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi.server=ALL-UNNAMED
> --add-opens=java.sql/java.sql=ALL-UNNAMED"
> fi
>
> CLASS=$1
>
> http://git-wip-us.apache.org/repos/asf/groovy/blob/
> 602ce052/src/bin/startGroovy.bat
> ----------------------------------------------------------------------
> diff --git a/src/bin/startGroovy.bat b/src/bin/startGroovy.bat
> index e4f784e..48709c7 100644
> --- a/src/bin/startGroovy.bat
> +++ b/src/bin/startGroovy.bat
> @@ -273,6 +273,7 @@ for /f "useback tokens=*" %%a in ('%JAVA_VERSION%') do
> set JAVA_VERSION=%%~a
> set JAVA_VERSION=%JAVA_VERSION:~0,5%
> set ADD_MODULES_OPT=--add-modules
> if "%JAVA_VERSION%" gtr "1.8.0" echo.%JAVA_OPTS% | findstr
> /C:"%ADD_MODULES_OPT%" >nul 2>&1 || set JAVA_OPTS=%JAVA_OPTS%
> %ADD_MODULES_OPT% ALL-SYSTEM
> +set JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.io=ALL-UNNAMED
> --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.annotation=ALL-UNNAMED
> --add-opens=java.base/java.lang.invoke=ALL-UNNAMED
> --add-opens=java.base/java.lang.module=ALL-UNNAMED
> --add-opens=java.base/java.lang.ref=ALL-UNNAMED
> --add-opens=java.base/java.lang.reflect=ALL-UNNAMED
> --add-opens=java.base/java.math=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED
> --add-opens=java.base/java.net.spi=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED
> --add-opens=java.base/java.nio.channels=ALL-UNNAMED
> --add-opens=java.base/java.nio.channels.spi=ALL-UNNAMED
> --add-opens=java.base/java.nio.charset=ALL-UNNAMED
> --add-opens=java.base/java.nio.charset.spi=ALL-UNNAMED
> --add-opens=java.base/java.nio.file=ALL-UNNAMED
> --add-opens=java.base/java.nio.file.attribute=ALL-UNNAMED
> --add-opens=java.base/java.nio.file.spi=ALL-UNNAMED
> --add-opens=java.base/java.security=ALL-UNNAMED
> --add-opens=java.base/java.secu
> rity.acl=ALL-UNNAMED --add-opens=java.base/java.security.cert=ALL-UNNAMED
> --add-opens=java.base/java.security.interfaces=ALL-UNNAMED
> --add-opens=java.base/java.security.spec=ALL-UNNAMED
> --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.base/java.text.spi=ALL-UNNAMED
> --add-opens=java.base/java.time=ALL-UNNAMED --add-opens=java.base/java.time.chrono=ALL-UNNAMED
> --add-opens=java.base/java.time.format=ALL-UNNAMED
> --add-opens=java.base/java.time.temporal=ALL-UNNAMED
> --add-opens=java.base/java.time.zone=ALL-UNNAMED
> --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED
> --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
> --add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED
> --add-opens=java.base/java.util.function=ALL-UNNAMED
> --add-opens=java.base/java.util.jar=ALL-UNNAMED
> --add-opens=java.base/java.util.regex=ALL-UNNAMED
> --add-opens=java.base/java.util.spi=ALL-UNNAMED
> --add-opens=java.base/java.util.stream=ALL-UNNAMED
> --add-opens=java.base/java.util.zip=ALL-UNNAMED
> --add-opens=java.datatransfer/java.awt.datatransfer=ALL-UNNAMED
> --add-opens=java.desktop/java.applet=ALL-UNNAMED
> --add-opens=java.desktop/java.awt=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.color=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.desktop=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.dnd=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.dnd.peer=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.event=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.font=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.geom=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.im=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.im.spi=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.image=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.image.renderable=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.peer=ALL-UNNAMED
> --add-opens=java.desktop/java.awt.print=ALL-UNNAMED
> --add-opens=java.desktop/java.beans=ALL-UNNAMED
> --add-opens=java.desktop/java.beans.beancontext=ALL-UNNA
> MED --add-opens=java.instrument/java.lang.instrument=ALL-UNNAMED
> --add-opens=java.logging/java.util.logging=ALL-UNNAMED
> --add-opens=java.management/java.lang.management=ALL-UNNAMED
> --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi=ALL-UNNAMED --add-opens=java.rmi/java.rmi.activation=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi.dgc=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi.registry=ALL-UNNAMED
> --add-opens=java.rmi/java.rmi.server=ALL-UNNAMED
> --add-opens=java.sql/java.sql=ALL-UNNAMED
>
> if exist "%USERPROFILE%/.groovy/postinit.bat" call
> "%USERPROFILE%/.groovy/postinit.bat"
>
>
>
Re: [1/2] groovy git commit: Turn off warnings from Java9: illegal
reflective access
Posted by Daniel Sun <re...@hotmail.com>.
Add a switch to turn off the warnings from Java9.
https://github.com/apache/groovy/commit/a7f7cdd352a40dd7acd2def999eb560c2b76904e
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [1/2] groovy git commit: Turn off warnings from Java9: illegal
reflective access
Posted by Cédric Champeau <ce...@gmail.com>.
It's not friendly but adding add opens have side effects. I'd prefer we
don't do this.
2017-09-29 16:53 GMT+02:00 Daniel Sun <re...@hotmail.com>:
> Hi Cédric,
>
> The warning is not friendly to groovy developers, who just want
> groovy program can run well and don't care how it is compiled and executed.
>
> But as groovy programming languange developer, we have to look into
> these warning, so we should remove these '--add-opens' to address issues.
>
> Cheers,
> Daniel.Sun
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>
Re: [1/2] groovy git commit: Turn off warnings from Java9: illegal
reflective access
Posted by Daniel Sun <re...@hotmail.com>.
Hi Cédric,
The warning is not friendly to groovy developers, who just want
groovy program can run well and don't care how it is compiled and executed.
But as groovy programming languange developer, we have to look into
these warning, so we should remove these '--add-opens' to address issues.
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html