You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/09/12 18:27:31 UTC
Review Request 62254: Ignored /proc/self/ns/pid_for_children when
listing namespaces.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62254/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-7968
https://issues.apache.org/jira/browse/MESOS-7968
Repository: mesos
Description
-------
Since Linux 4.12, /proc/self/ns/pid_for_children is a handle for the PID namespace of child processes created by this process. Since this is not a namespace type in its own, we should ignore this file when listing namespaces via `ls /proc/self/ns`.
Diffs
-----
src/linux/ns.hpp f1792e854e3fb40321a6ad3f7d1f0f9fbd03761a
Diff: https://reviews.apache.org/r/62254/diff/1/
Testing
-------
make check on Fedora 26.
Thanks,
Kapil Arya
Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when
listing namespaces.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62254/#review185238
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 12, 2017, 6:27 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62254/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 6:27 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7968
> https://issues.apache.org/jira/browse/MESOS-7968
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since Linux 4.12, /proc/self/ns/pid_for_children is a handle for the PID namespace of child processes created by this process. Since this is not a namespace type in its own, we should ignore this file when listing namespaces via `ls /proc/self/ns`.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp f1792e854e3fb40321a6ad3f7d1f0f9fbd03761a
>
>
> Diff: https://reviews.apache.org/r/62254/diff/1/
>
>
> Testing
> -------
>
> make check on Fedora 26.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when
listing namespaces.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62254/#review185251
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['62253', '62254']`
Failed command: `C:\mesos\src\mesos-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62254
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62254/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (199 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (200 ms)
[----------] 30 tests from ContentType/SchedulerTest (21219 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (702 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (855 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (1649 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (134 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (154 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (329 ms total)
[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (284404 ms total)
[ PASSED ] 626 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.SigkillExecutor/0, where GetParam() = "mesos"
1 FAILED TEST
YOU HAVE 174 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62254/logs/mesos-tests-stderr.log):
```
I0912 23:17:48.760558 12128 default_executor.cpp:185] Received ACKNOWLEDGED event
I0912 23:17:49.272580 11968 default_executor.cpp:842] Child container 724375d3-5c44-48de-ab1a-e621a5ead895.51c7115b-4f38-401d-934d-23c4cced1f66 of task 'eee2f001-d3f6-4842-a5af-f500d949ef0d' in state TASK_FAILED exited with status 1
I0912 23:17:49.272580 11968 default_executor.cpp:964] Terminating after 1secs
I0912 23:17:50.275440 10392 process.cpp:1068] Failed to accept socket: future discarded
'\?\C:\Users\mesos\AppData\Local\Temp\2\v5qPD5\slaves\32e4c40a-33ec-4144-84db-c1519b62de43-S0\frameworks\32e4c40a-33ec-4144-84db-c1519b62de43-0000\executors\default\runs\bf8acb4d-41db-49d5-9548-ba37e82b1d1c\containers\10fc31f1-e35a-4236-9a7b-39f62570289e'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported. Defaulting to Windows directory.
'\?\C:\Users\mesos\AppData\Local\Temp\2\v5qPD5\slaves\32e4c40a-33ec-4144-84db-c1519b62de43-S0\frameworks\32e4c40a-33ec-4144-84db-c1519b62de43-0000\executors\default\runs\bf8acb4d-41db-49d5-9548-ba37e82b1d1c\containers\79bf6b5e-3c03-4452-b327-339cb0058608'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported. Defaulting to Windows directory.
I0912 23:17:51.654733 12976 executor.cpp:192] Version: 1.5.0
I0912 23:17:51.713738 12920 default_executor.cpp:185] Received SUBSCRIBED event
I0912 23:17:51.728744 12920 default_executor.cpp:189] Subscribed executor on mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0912 23:17:51.733744 12920 default_executor.cpp:185] Received LAUNCH_GROUP event
I0912 23:17:51.736744 12920 default_executor.cpp:394] Setting 'MESOS_CONTAINER_IP' to: 10.3.1.5
I0912 23:17:52.016747 12920 default_executor.cpp:624] Successfully launched tasks [ ba34a8c9-cc79-49fe-8472-bf3b271d9ad9, 4ca81226-60ab-4cea-a946-5d163e59292c ] in child containers [ bf8acb4d-41db-49d5-9548-ba37e82b1d1c.10fc31f1-e35a-4236-9a7b-39f62570289e, bf8acb4d-41db-49d5-9548-ba37e82b1d1c.79bf6b5e-3c03-4452-b327-339cb0058608 ]
I0912 23:17:52.034749 13096 default_executor.cpp:697] Waiting for child container bf8acb4d-41db-49d5-9548-ba37e82b1d1c.10fc31f1-e35a-4236-9a7b-39f62570289e of task 'ba34a8c9-cc79-49fe-8472-bf3b271d9ad9'
I0912 23:17:52.035748 13096 default_executor.cpp:697] Waiting for child container bf8acb4d-41db-49d5-9548-ba37e82b1d1c.79bf6b5e-3c03-4452-b327-339cb0058608 of task '4ca81226-60ab-4cea-a946-5d163e59292c'
I0912 23:17:52.139567 5240 default_executor.cpp:185] Received ACKNOWLEDGED event
I0912 23:17:52.142751 12788 default_executor.cpp:185] Received ACKNOWLEDGED event
I0912 23:17:52.563763 13136 default_executor.cpp:842] Child container bf8acb4d-41db-49d5-9548-ba37e82b1d1c.10fc31f1-e35a-4236-9a7b-39f62570289e of task 'ba34a8c9-cc79-49fe-8472-bf3b271d9ad9' in state TASK_FINISHED exited with status 0
I0912 23:17:52.564764 13136 default_executor.cpp:185] Received ACKNOWLEDGED event
I0912 23:17:52.564764 13136 default_executor.cpp:185] Received KILL event
I0912 23:17:52.564764 13136 default_executor.cpp:1119] Received kill for task '4ca81226-60ab-4cea-a946-5d163e59292c'
I0912 23:17:52.569767 13136 default_executor.cpp:1004] Killing task 4ca81226-60ab-4cea-a946-5d163e59292c running in child container bf8acb4d-41db-49d5-9548-ba37e82b1d1c.79bf6b5e-3c03-4452-b327-339cb0058608 with SIGTERM signal
I0912 23:17:52.569767 13136 default_executor.cpp:1026] Scheduling escalation to SIGKILL in 3secs from now
I0912 23:17:52.644774 12920 default_executor.cpp:842] Child container bf8acb4d-41db-49d5-9548-ba37e82b1d1c.79bf6b5e-3c03-4452-b327-339cb0058608 of task '4ca81226-60ab-4cea-a946-5d163e59292c' in state TASK_KILLED exited with status 1
I0912 23:17:52.644774 12920 default_executor.cpp:964] Terminating after 1secs
I0912 23:17:53.651178 7596 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Sept. 12, 2017, 9:27 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62254/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 9:27 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7968
> https://issues.apache.org/jira/browse/MESOS-7968
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since Linux 4.12, /proc/self/ns/pid_for_children is a handle for the PID namespace of child processes created by this process. Since this is not a namespace type in its own, we should ignore this file when listing namespaces via `ls /proc/self/ns`.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp f1792e854e3fb40321a6ad3f7d1f0f9fbd03761a
>
>
> Diff: https://reviews.apache.org/r/62254/diff/1/
>
>
> Testing
> -------
>
> make check on Fedora 26.
>
>
> Thanks,
>
> Kapil Arya
>
>