You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by bf...@apache.org on 2011/02/23 18:17:40 UTC

svn commit: r1073835 - in /oodt/trunk: CHANGES.txt commons/src/main/java/org/apache/oodt/commons/exec/StreamGobbler.java

Author: bfoster
Date: Wed Feb 23 17:17:39 2011
New Revision: 1073835

URL: http://svn.apache.org/viewvc?rev=1073835&view=rev
Log:

- modified StreamGobbler to send it's exception capturing to the Java Logger as FINEST instead of to stdout so by default it is silenced

--------------------------

OODT-145

Modified:
    oodt/trunk/CHANGES.txt
    oodt/trunk/commons/src/main/java/org/apache/oodt/commons/exec/StreamGobbler.java

Modified: oodt/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/oodt/trunk/CHANGES.txt?rev=1073835&r1=1073834&r2=1073835&view=diff
==============================================================================
--- oodt/trunk/CHANGES.txt (original)
+++ oodt/trunk/CHANGES.txt Wed Feb 23 17:17:39 2011
@@ -4,6 +4,9 @@ Apache OODT Change Log
 Release 0.3-SNAPSHOT (in progress)
 --------------------------------------------
 
+* OODT-145 StreamGobbler stopGobblingAndDie() method doesn't wait 
+  until gobble is really dead (bfoster)
+
 * OODT-112 Link to slides on web-grid Maven page is broke (mattmann, goodale)
 
 * OODT-130 Fixed mailing list links for CAS Components maven generated site pages (goodale)

Modified: oodt/trunk/commons/src/main/java/org/apache/oodt/commons/exec/StreamGobbler.java
URL: http://svn.apache.org/viewvc/oodt/trunk/commons/src/main/java/org/apache/oodt/commons/exec/StreamGobbler.java?rev=1073835&r1=1073834&r2=1073835&view=diff
==============================================================================
--- oodt/trunk/commons/src/main/java/org/apache/oodt/commons/exec/StreamGobbler.java (original)
+++ oodt/trunk/commons/src/main/java/org/apache/oodt/commons/exec/StreamGobbler.java Wed Feb 23 17:17:39 2011
@@ -35,8 +35,13 @@ import java.io.PrintWriter;
 import java.io.BufferedReader;
 import java.io.InputStreamReader;
 import java.io.IOException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 public class StreamGobbler extends Thread {
+	
+	private static final Logger LOG = Logger.getLogger(StreamGobbler.class.getName());
+	
     InputStream is;
 
     String type;
@@ -71,7 +76,7 @@ public class StreamGobbler extends Threa
             if (pw != null)
                 pw.flush();
         } catch (IOException ioe) {
-            ioe.printStackTrace();
+        	LOG.log(Level.FINEST, "StreamGobbler failed while gobbling : " + ioe.getMessage(), ioe);
         }
     }