[jira] Commented: (CHUKWA-562) Use RegexFileFilter instead of WildcardFileFilter in the DirTailingAdaptor class

["Ari Rabkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CHUKWA-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965481#action_12965481 ] 

Ari Rabkin commented on CHUKWA-562:
-----------------------------------

I'm uneasy with this patch. I think regular expressions are slightly less intuitive for most users. Moreover, this breaks the existing user interface.  Deepak, how would you feel about instead having a subclass of DirTailingAdaptor with regex patterns?

> Use RegexFileFilter instead of WildcardFileFilter in the DirTailingAdaptor class
> --------------------------------------------------------------------------------
>
>                 Key: CHUKWA-562
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-562
>             Project: Chukwa
>          Issue Type: Improvement
>          Components: data collection
>    Affects Versions: 0.4.0
>            Reporter: Deepak Deshpande
>            Priority: Minor
>             Fix For: 0.5.0
>
>         Attachments: DirTailingAdaptor.patch
>
>
> The DirTailingAdaptor class uses WildcardFileFilter to filter the files that need to be monitored. The WildcardFileFilter is NOT very restrictive. Instead of WildcardFileFilter using RegexFileFilter will give user more flexibility in file filtering.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.