You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "Noah-Nelson (via GitHub)" <gi...@apache.org> on 2026/02/11 19:45:27 UTC

[I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Noah-Nelson opened a new issue, #37905:
URL: https://github.com/apache/superset/issues/37905

## Screenshot

## Description

1. With the dark theme / dark mode on AND "show total" checked for a sunburst chart, the total value (displayed at the center of the chart) is displayed in black text with the dark theme background, making it virtually illegible.
2. The labels for the starburst chart when dark theme/mode is active appear as white text with a black outline. Even at a fairly large size this makes them difficult to read.

## Design input

1. `design:suggest` display total value using white/light foregrounded text color when dark theme/mode is active.
2. `design:suggest` display labels in either white/light or black/dark text with no outline. If the colors used by the theme are sufficiently bright but saturated (as they are in this screenshot), either should work, though white/light might be preferred.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Posted by "Noah-Nelson (via GitHub)" <gi...@apache.org>.

Noah-Nelson commented on issue #37905:
URL: https://github.com/apache/superset/issues/37905#issuecomment-3946396874

   @MelikHajlawi I actually noticed the black-outlined white text labels may not be specific to the dark theme, it may be a more general design choice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Posted by "MelikHajlawi (via GitHub)" <gi...@apache.org>.

MelikHajlawi commented on issue #37905:
URL: https://github.com/apache/superset/issues/37905#issuecomment-3938599069

   Hello, I tested on the latest master branch (0.0.0-dev) with dark theme and "show total" enabled. The centre total now appears white and is readable, which is great. However, the segment labels are still white with a black outline, as originally described. So the issue is partially fixed – only the label outline remains. I'd like to work on removing the outline to fully resolve this. Could this be assigned to me?
   
   <img width="1575" height="763" alt="Image" src="https://github.com/user-attachments/assets/cbdf973b-6bd9-4d94-b7eb-fd73e542bb55" />


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #37905:
URL: https://github.com/apache/superset/issues/37905#issuecomment-4013223470

   I think this should even be smarter than just picking the theme font color... it should be smart enough to _invert_ that for maximum contrast... e.g. black text on a pale yellow area, and white text on a dark red area. PR welcomed!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Posted by "Abdulrehman-PIAIC80387 (via GitHub)" <gi...@apache.org>.

Abdulrehman-PIAIC80387 commented on issue #37905:
URL: https://github.com/apache/superset/issues/37905#issuecomment-4286361824

   Hi @rusackas — I'd love to work on this one! Planning to use the approach you suggested: compute a contrasting text color based on each slice's background (light text on dark backgrounds, dark text on light backgrounds) for maximum legibility across themes, and drop the black stroke. Will open a PR shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #37905:
URL: https://github.com/apache/superset/issues/37905#issuecomment-4013225429

   .... but yeah, the stroke on the text is kind of gross. High-contrast single-color text would be the win.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas closed issue #37905: Dark Theme: Starburst chart "total" displayed in black, labels in white with black outline
URL: https://github.com/apache/superset/issues/37905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org