You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/05 18:52:32 UTC
[GitHub] [airflow] josh-fell opened a new pull request #19431: Update Azure modules to comply with AIP-21
josh-fell opened a new pull request #19431:
URL: https://github.com/apache/airflow/pull/19431
Closes: #17898
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#issuecomment-962602946
The label should print more information while tests are running (as it used to be when I introduced parallel runs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#issuecomment-962149471
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743917797
##########
File path: airflow/contrib/hooks/azure_container_registry_hook.py
##########
@@ -15,20 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""
-This module is deprecated.
-Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.
-"""
+"""This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`."""
import warnings
-from airflow.providers.microsoft.azure.hooks.azure_container_registry import ( # noqa
- AzureContainerRegistryHook,
-)
+from airflow.providers.microsoft.azure.hooks.container_registry import AzureContainerRegistryHook # noqa
warnings.warn(
- "This module is deprecated. "
- "Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.",
+ "This module is deprecated. " "Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
Review comment:
```suggestion
"This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743918092
##########
File path: airflow/providers/microsoft/azure/operators/azure_cosmos.py
##########
@@ -15,56 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+"""This module is deprecated. Please use :mod:`airflow.providers.microsoft.azure.operators.cosmos`."""
-from airflow.models import BaseOperator
-from airflow.providers.microsoft.azure.hooks.azure_cosmos import AzureCosmosDBHook
-
-
-class AzureCosmosInsertDocumentOperator(BaseOperator):
- """
- Inserts a new document into the specified Cosmos database and collection
- It will create both the database and collection if they do not already exist
-
- :param database_name: The name of the database. (templated)
- :type database_name: str
- :param collection_name: The name of the collection. (templated)
- :type collection_name: str
- :param document: The document to insert
- :type document: dict
- :param azure_cosmos_conn_id: Reference to the
- :ref:`Azure CosmosDB connection<howto/connection:azure_cosmos>`.
- :type azure_cosmos_conn_id: str
- """
-
- template_fields = ('database_name', 'collection_name')
- ui_color = '#e4f0e8'
-
- def __init__(
- self,
- *,
- database_name: str,
- collection_name: str,
- document: dict,
- azure_cosmos_conn_id: str = 'azure_cosmos_default',
- **kwargs,
- ) -> None:
- super().__init__(**kwargs)
- self.database_name = database_name
- self.collection_name = collection_name
- self.document = document
- self.azure_cosmos_conn_id = azure_cosmos_conn_id
-
- def execute(self, context: dict) -> None:
- # Create the hook
- hook = AzureCosmosDBHook(azure_cosmos_conn_id=self.azure_cosmos_conn_id)
-
- # Create the DB if it doesn't already exist
- if not hook.does_database_exist(self.database_name):
- hook.create_database(self.database_name)
+import warnings
- # Create the collection as well
- if not hook.does_collection_exist(self.collection_name, self.database_name):
- hook.create_collection(self.collection_name, self.database_name)
+from airflow.providers.microsoft.azure.operators.cosmo import AzureCosmosInsertDocumentOperator # noqa
Review comment:
```suggestion
from airflow.providers.microsoft.azure.operators.cosmos import AzureCosmosInsertDocumentOperator # noqa
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell closed pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell closed pull request #19431:
URL: https://github.com/apache/airflow/pull/19431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell closed pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell closed pull request #19431:
URL: https://github.com/apache/airflow/pull/19431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#issuecomment-962602851
Seems that we have a problem with resources on github public runners. I added the "debug-ci-resources" label to the PR and close/reopen it to see more details on resources used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743919483
##########
File path: airflow/contrib/hooks/azure_container_registry_hook.py
##########
@@ -15,20 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""
-This module is deprecated.
-Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.
-"""
+"""This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`."""
import warnings
-from airflow.providers.microsoft.azure.hooks.azure_container_registry import ( # noqa
- AzureContainerRegistryHook,
-)
+from airflow.providers.microsoft.azure.hooks.container_registry import AzureContainerRegistryHook # noqa
warnings.warn(
- "This module is deprecated. "
- "Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.",
+ "This module is deprecated. " "Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
Review comment:
Nice catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell closed pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell closed pull request #19431:
URL: https://github.com/apache/airflow/pull/19431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743918847
##########
File path: airflow/providers/microsoft/azure/operators/azure_cosmos.py
##########
@@ -15,56 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+"""This module is deprecated. Please use :mod:`airflow.providers.microsoft.azure.operators.cosmos`."""
-from airflow.models import BaseOperator
-from airflow.providers.microsoft.azure.hooks.azure_cosmos import AzureCosmosDBHook
-
-
-class AzureCosmosInsertDocumentOperator(BaseOperator):
- """
- Inserts a new document into the specified Cosmos database and collection
- It will create both the database and collection if they do not already exist
-
- :param database_name: The name of the database. (templated)
- :type database_name: str
- :param collection_name: The name of the collection. (templated)
- :type collection_name: str
- :param document: The document to insert
- :type document: dict
- :param azure_cosmos_conn_id: Reference to the
- :ref:`Azure CosmosDB connection<howto/connection:azure_cosmos>`.
- :type azure_cosmos_conn_id: str
- """
-
- template_fields = ('database_name', 'collection_name')
- ui_color = '#e4f0e8'
-
- def __init__(
- self,
- *,
- database_name: str,
- collection_name: str,
- document: dict,
- azure_cosmos_conn_id: str = 'azure_cosmos_default',
- **kwargs,
- ) -> None:
- super().__init__(**kwargs)
- self.database_name = database_name
- self.collection_name = collection_name
- self.document = document
- self.azure_cosmos_conn_id = azure_cosmos_conn_id
-
- def execute(self, context: dict) -> None:
- # Create the hook
- hook = AzureCosmosDBHook(azure_cosmos_conn_id=self.azure_cosmos_conn_id)
-
- # Create the DB if it doesn't already exist
- if not hook.does_database_exist(self.database_name):
- hook.create_database(self.database_name)
+import warnings
- # Create the collection as well
- if not hook.does_collection_exist(self.collection_name, self.database_name):
- hook.create_collection(self.collection_name, self.database_name)
+from airflow.providers.microsoft.azure.operators.cosmo import AzureCosmosInsertDocumentOperator # noqa
Review comment:
Yeah just saw that test fail too.
##########
File path: airflow/contrib/hooks/azure_container_registry_hook.py
##########
@@ -15,20 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""
-This module is deprecated.
-Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.
-"""
+"""This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`."""
import warnings
-from airflow.providers.microsoft.azure.hooks.azure_container_registry import ( # noqa
- AzureContainerRegistryHook,
-)
+from airflow.providers.microsoft.azure.hooks.container_registry import AzureContainerRegistryHook # noqa
warnings.warn(
- "This module is deprecated. "
- "Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.",
+ "This module is deprecated. " "Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
Review comment:
Nice catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19431:
URL: https://github.com/apache/airflow/pull/19431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #19431:
URL: https://github.com/apache/airflow/pull/19431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743918847
##########
File path: airflow/providers/microsoft/azure/operators/azure_cosmos.py
##########
@@ -15,56 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+"""This module is deprecated. Please use :mod:`airflow.providers.microsoft.azure.operators.cosmos`."""
-from airflow.models import BaseOperator
-from airflow.providers.microsoft.azure.hooks.azure_cosmos import AzureCosmosDBHook
-
-
-class AzureCosmosInsertDocumentOperator(BaseOperator):
- """
- Inserts a new document into the specified Cosmos database and collection
- It will create both the database and collection if they do not already exist
-
- :param database_name: The name of the database. (templated)
- :type database_name: str
- :param collection_name: The name of the collection. (templated)
- :type collection_name: str
- :param document: The document to insert
- :type document: dict
- :param azure_cosmos_conn_id: Reference to the
- :ref:`Azure CosmosDB connection<howto/connection:azure_cosmos>`.
- :type azure_cosmos_conn_id: str
- """
-
- template_fields = ('database_name', 'collection_name')
- ui_color = '#e4f0e8'
-
- def __init__(
- self,
- *,
- database_name: str,
- collection_name: str,
- document: dict,
- azure_cosmos_conn_id: str = 'azure_cosmos_default',
- **kwargs,
- ) -> None:
- super().__init__(**kwargs)
- self.database_name = database_name
- self.collection_name = collection_name
- self.document = document
- self.azure_cosmos_conn_id = azure_cosmos_conn_id
-
- def execute(self, context: dict) -> None:
- # Create the hook
- hook = AzureCosmosDBHook(azure_cosmos_conn_id=self.azure_cosmos_conn_id)
-
- # Create the DB if it doesn't already exist
- if not hook.does_database_exist(self.database_name):
- hook.create_database(self.database_name)
+import warnings
- # Create the collection as well
- if not hook.does_collection_exist(self.collection_name, self.database_name):
- hook.create_collection(self.collection_name, self.database_name)
+from airflow.providers.microsoft.azure.operators.cosmo import AzureCosmosInsertDocumentOperator # noqa
Review comment:
Yeah just saw that test fail too.
##########
File path: airflow/contrib/hooks/azure_container_registry_hook.py
##########
@@ -15,20 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""
-This module is deprecated.
-Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.
-"""
+"""This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`."""
import warnings
-from airflow.providers.microsoft.azure.hooks.azure_container_registry import ( # noqa
- AzureContainerRegistryHook,
-)
+from airflow.providers.microsoft.azure.hooks.container_registry import AzureContainerRegistryHook # noqa
warnings.warn(
- "This module is deprecated. "
- "Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.",
+ "This module is deprecated. " "Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
Review comment:
Nice catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
josh-fell commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743918847
##########
File path: airflow/providers/microsoft/azure/operators/azure_cosmos.py
##########
@@ -15,56 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+"""This module is deprecated. Please use :mod:`airflow.providers.microsoft.azure.operators.cosmos`."""
-from airflow.models import BaseOperator
-from airflow.providers.microsoft.azure.hooks.azure_cosmos import AzureCosmosDBHook
-
-
-class AzureCosmosInsertDocumentOperator(BaseOperator):
- """
- Inserts a new document into the specified Cosmos database and collection
- It will create both the database and collection if they do not already exist
-
- :param database_name: The name of the database. (templated)
- :type database_name: str
- :param collection_name: The name of the collection. (templated)
- :type collection_name: str
- :param document: The document to insert
- :type document: dict
- :param azure_cosmos_conn_id: Reference to the
- :ref:`Azure CosmosDB connection<howto/connection:azure_cosmos>`.
- :type azure_cosmos_conn_id: str
- """
-
- template_fields = ('database_name', 'collection_name')
- ui_color = '#e4f0e8'
-
- def __init__(
- self,
- *,
- database_name: str,
- collection_name: str,
- document: dict,
- azure_cosmos_conn_id: str = 'azure_cosmos_default',
- **kwargs,
- ) -> None:
- super().__init__(**kwargs)
- self.database_name = database_name
- self.collection_name = collection_name
- self.document = document
- self.azure_cosmos_conn_id = azure_cosmos_conn_id
-
- def execute(self, context: dict) -> None:
- # Create the hook
- hook = AzureCosmosDBHook(azure_cosmos_conn_id=self.azure_cosmos_conn_id)
-
- # Create the DB if it doesn't already exist
- if not hook.does_database_exist(self.database_name):
- hook.create_database(self.database_name)
+import warnings
- # Create the collection as well
- if not hook.does_collection_exist(self.collection_name, self.database_name):
- hook.create_collection(self.collection_name, self.database_name)
+from airflow.providers.microsoft.azure.operators.cosmo import AzureCosmosInsertDocumentOperator # noqa
Review comment:
Yeah just saw that test fail too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#issuecomment-962149471
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743917797
##########
File path: airflow/contrib/hooks/azure_container_registry_hook.py
##########
@@ -15,20 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""
-This module is deprecated.
-Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.
-"""
+"""This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`."""
import warnings
-from airflow.providers.microsoft.azure.hooks.azure_container_registry import ( # noqa
- AzureContainerRegistryHook,
-)
+from airflow.providers.microsoft.azure.hooks.container_registry import AzureContainerRegistryHook # noqa
warnings.warn(
- "This module is deprecated. "
- "Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.",
+ "This module is deprecated. " "Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
Review comment:
```suggestion
"This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#issuecomment-962149471
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743918092
##########
File path: airflow/providers/microsoft/azure/operators/azure_cosmos.py
##########
@@ -15,56 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+"""This module is deprecated. Please use :mod:`airflow.providers.microsoft.azure.operators.cosmos`."""
-from airflow.models import BaseOperator
-from airflow.providers.microsoft.azure.hooks.azure_cosmos import AzureCosmosDBHook
-
-
-class AzureCosmosInsertDocumentOperator(BaseOperator):
- """
- Inserts a new document into the specified Cosmos database and collection
- It will create both the database and collection if they do not already exist
-
- :param database_name: The name of the database. (templated)
- :type database_name: str
- :param collection_name: The name of the collection. (templated)
- :type collection_name: str
- :param document: The document to insert
- :type document: dict
- :param azure_cosmos_conn_id: Reference to the
- :ref:`Azure CosmosDB connection<howto/connection:azure_cosmos>`.
- :type azure_cosmos_conn_id: str
- """
-
- template_fields = ('database_name', 'collection_name')
- ui_color = '#e4f0e8'
-
- def __init__(
- self,
- *,
- database_name: str,
- collection_name: str,
- document: dict,
- azure_cosmos_conn_id: str = 'azure_cosmos_default',
- **kwargs,
- ) -> None:
- super().__init__(**kwargs)
- self.database_name = database_name
- self.collection_name = collection_name
- self.document = document
- self.azure_cosmos_conn_id = azure_cosmos_conn_id
-
- def execute(self, context: dict) -> None:
- # Create the hook
- hook = AzureCosmosDBHook(azure_cosmos_conn_id=self.azure_cosmos_conn_id)
-
- # Create the DB if it doesn't already exist
- if not hook.does_database_exist(self.database_name):
- hook.create_database(self.database_name)
+import warnings
- # Create the collection as well
- if not hook.does_collection_exist(self.collection_name, self.database_name):
- hook.create_collection(self.collection_name, self.database_name)
+from airflow.providers.microsoft.azure.operators.cosmo import AzureCosmosInsertDocumentOperator # noqa
Review comment:
```suggestion
from airflow.providers.microsoft.azure.operators.cosmos import AzureCosmosInsertDocumentOperator # noqa
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743917797
##########
File path: airflow/contrib/hooks/azure_container_registry_hook.py
##########
@@ -15,20 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""
-This module is deprecated.
-Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.
-"""
+"""This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`."""
import warnings
-from airflow.providers.microsoft.azure.hooks.azure_container_registry import ( # noqa
- AzureContainerRegistryHook,
-)
+from airflow.providers.microsoft.azure.hooks.container_registry import AzureContainerRegistryHook # noqa
warnings.warn(
- "This module is deprecated. "
- "Please use `airflow.providers.microsoft.azure.hooks.azure_container_registry`.",
+ "This module is deprecated. " "Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
Review comment:
```suggestion
"This module is deprecated. Please use `airflow.providers.microsoft.azure.hooks.container_registry`.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19431: Update Azure modules to comply with AIP-21
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19431:
URL: https://github.com/apache/airflow/pull/19431#discussion_r743918092
##########
File path: airflow/providers/microsoft/azure/operators/azure_cosmos.py
##########
@@ -15,56 +14,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+"""This module is deprecated. Please use :mod:`airflow.providers.microsoft.azure.operators.cosmos`."""
-from airflow.models import BaseOperator
-from airflow.providers.microsoft.azure.hooks.azure_cosmos import AzureCosmosDBHook
-
-
-class AzureCosmosInsertDocumentOperator(BaseOperator):
- """
- Inserts a new document into the specified Cosmos database and collection
- It will create both the database and collection if they do not already exist
-
- :param database_name: The name of the database. (templated)
- :type database_name: str
- :param collection_name: The name of the collection. (templated)
- :type collection_name: str
- :param document: The document to insert
- :type document: dict
- :param azure_cosmos_conn_id: Reference to the
- :ref:`Azure CosmosDB connection<howto/connection:azure_cosmos>`.
- :type azure_cosmos_conn_id: str
- """
-
- template_fields = ('database_name', 'collection_name')
- ui_color = '#e4f0e8'
-
- def __init__(
- self,
- *,
- database_name: str,
- collection_name: str,
- document: dict,
- azure_cosmos_conn_id: str = 'azure_cosmos_default',
- **kwargs,
- ) -> None:
- super().__init__(**kwargs)
- self.database_name = database_name
- self.collection_name = collection_name
- self.document = document
- self.azure_cosmos_conn_id = azure_cosmos_conn_id
-
- def execute(self, context: dict) -> None:
- # Create the hook
- hook = AzureCosmosDBHook(azure_cosmos_conn_id=self.azure_cosmos_conn_id)
-
- # Create the DB if it doesn't already exist
- if not hook.does_database_exist(self.database_name):
- hook.create_database(self.database_name)
+import warnings
- # Create the collection as well
- if not hook.does_collection_exist(self.collection_name, self.database_name):
- hook.create_collection(self.collection_name, self.database_name)
+from airflow.providers.microsoft.azure.operators.cosmo import AzureCosmosInsertDocumentOperator # noqa
Review comment:
```suggestion
from airflow.providers.microsoft.azure.operators.cosmos import AzureCosmosInsertDocumentOperator # noqa
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org