You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/14 03:35:45 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #6443: Scan thread num
morningman opened a new pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443
## Proposed changes
Details see #6442
I add a new session variable "cpu_resource_limit" and a new user property "cpu_resource_limit".
The default value is -1, which is unlimited. And user can set limit for a single query in a session,
or set the limit for a certain user, so that all queries the user execute will use this limit.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6442) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443#discussion_r695327788
##########
File path: gensrc/thrift/PaloInternalService.thrift
##########
@@ -77,6 +77,10 @@ struct TLoadErrorHubInfo {
3: optional TBrokerErrorHubInfo broker_info;
}
+struct TResourceLimit {
+ 1: optional i32 cpu_limit
Review comment:
> maybe use max_concurrency is better
In fact, what I want to express is that this value is not bound to any implementation. It does not represent the number of threads or the number of concurrency, but a relative value.
It is more like a priority concept, or similar to the concept of weight in cgroups.
In this way, we can continue to use this parameter when we implement more refined resource isolation in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] killxdcj commented on a change in pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
killxdcj commented on a change in pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443#discussion_r689202511
##########
File path: fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java
##########
@@ -339,6 +363,9 @@ public String getDefaultLoadCluster() {
// sql block rules
result.add(Lists.newArrayList(PROP_SQL_BLOCK_RULES, commonProperties.getSqlBlockRules()));
+ // sql block rules
Review comment:
The comment is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] killxdcj commented on a change in pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
killxdcj commented on a change in pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443#discussion_r689207017
##########
File path: gensrc/thrift/PaloInternalService.thrift
##########
@@ -77,6 +77,10 @@ struct TLoadErrorHubInfo {
3: optional TBrokerErrorHubInfo broker_info;
}
+struct TResourceLimit {
+ 1: optional i32 cpu_limit
Review comment:
Maybe It is better to use a name such as scannode_max_parallelism xxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443#discussion_r689600907
##########
File path: gensrc/thrift/PaloInternalService.thrift
##########
@@ -77,6 +77,10 @@ struct TLoadErrorHubInfo {
3: optional TBrokerErrorHubInfo broker_info;
}
+struct TResourceLimit {
+ 1: optional i32 cpu_limit
Review comment:
I want to decouple the struct with the certain implementation.
So that we can extend this feature in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443#discussion_r694644065
##########
File path: gensrc/thrift/PaloInternalService.thrift
##########
@@ -77,6 +77,10 @@ struct TLoadErrorHubInfo {
3: optional TBrokerErrorHubInfo broker_info;
}
+struct TResourceLimit {
+ 1: optional i32 cpu_limit
Review comment:
maybe use max_concurrency is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6443: [ResourceLimit] Limit CPU resource usage of each query
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6443:
URL: https://github.com/apache/incubator-doris/pull/6443#issuecomment-905244634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org