You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/04/30 09:26:03 UTC

[GitHub] [arrow] lidavidm commented on issue #35373: [C++][FlightRPC] Add support for using HTTP headers or query parameters in ServerAuthHandler

lidavidm commented on issue #35373:
URL: https://github.com/apache/arrow/issues/35373#issuecomment-1528979791

   Is this basically the same idea as #34817?
   
   I'm reluctant to expand Handshake because it's stateful. I think the explicit messages in that PR are better, along with support for just passing the value via headers always.
   
   That said, if we are to expand this method I think it should be via adding `const ServerCallContext& context` because technically you are in an RPC call during execution.
   
   > But we also need to add `ServerCallContext::incoming_headers()` for this idea.
   
   I think we should do this anyways.
   
   > I want to receive database name via a HTTP header or a HTTP query parameter in https://github.com/apache/arrow-flight-sql-postgresql .
   
   I don't think query parameters get passed through via gRPC, unfortunately. So only headers would work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org