You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "henrikingo (via GitHub)" <gi...@apache.org> on 2023/04/20 14:11:28 UTC

[GitHub] [cassandra] henrikingo commented on a diff in pull request #2285: CASSANDRA-18260 Add details to Error: Not enough space for compaction

henrikingo commented on code in PR #2285:
URL: https://github.com/apache/cassandra/pull/2285#discussion_r1172653093


##########
src/java/org/apache/cassandra/db/Directories.java:
##########
@@ -492,18 +492,39 @@ public boolean hasAvailableDiskSpace(long estimatedSSTables, long expectedTotalW
     {
         long writeSize = expectedTotalWriteSize / estimatedSSTables;
         long totalAvailable = 0L;
+        boolean hasSpace = true;

Review Comment:
   Nowhere, apparently. It is used in the trunk version, where this check has a different structure.
   
   I'll remove it and thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org