You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by PivotalSarge <gi...@git.apache.org> on 2017/01/31 17:00:55 UTC
[GitHub] geode pull request #376: GEODE-2344: Updated the ordinal to match 9.0.
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode/pull/376
GEODE-2344: Updated the ordinal to match 9.0.
- Switch to the correct constructor to avoid errors.
- Remove unnecessary mechanism to modify version ordinal.
- Remove commented-out code.
- Account for extra bytes in the handshaking after 8.2.
- Refactor accommodating UUID and weight during handshake.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PivotalSarge/geode feature/GEODE-2344
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/376.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #376
----
commit b1928d0e8ed7f4c02659887a7b9f2a207a14aa1f
Author: Sarge <md...@pivotal.io>
Date: 2017-01-25T21:12:06Z
GEODE-2344: Updated the ordinal to match 9.0.
- Switch to the correct constructor to avoid errors.
- Remove unnecessary mechanism to modify version ordinal.
- Remove commented-out code.
- Account for extra bytes in the handshaking after 8.2.
- Refactor accommodating UUID and weight during handshake.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #376: GEODE-2344: Updated the ordinal to match 9.0.
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/376
I will just add a comment to the line that this is the Geode 1.0.0 ordinal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #376: GEODE-2344: Updated the ordinal to match 9.0.
Posted by PivotalSarge <gi...@git.apache.org>.
Github user PivotalSarge closed the pull request at:
https://github.com/apache/geode/pull/376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #376: GEODE-2344: Updated the ordinal to match 9.0.
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/376
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #376: GEODE-2344: Updated the ordinal to match 9.0.
Posted by PivotalSarge <gi...@git.apache.org>.
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/376
It's just an integer literal value for a static constant variable called ordinal. Are you think along the lines of the remove #define statements? Is your concern determining which version of the wire protocol is supported?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---