[jira] [Commented] (FLINK-4134) EventTimeSessionWindows trigger for empty windows when dropping late events

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361254#comment-15361254 ] 

ASF GitHub Bot commented on FLINK-4134:
---------------------------------------

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/2196

    [FLINK-4134] empty session windows fire for late events

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    …e session accidentally created a triggering empty window

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink 4134-EmptySessionWindowsFire

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2196
    
----
commit 0e7bf5d9244ba4ea529c9037e680c9bfdf2069f9
Author: Stefan Richter <s....@data-artisans.com>
Date:   2016-07-04T12:32:42Z

    [FLINK-4134] [Runtime] Bugfix: multiple late elements that fall in one session accidentally created a triggering empty window

commit e82c5a623854d76be958176027d44e948810e609
Author: Stefan Richter <s....@data-artisans.com>
Date:   2016-07-04T12:36:43Z

    FLINK-4134] [Runtime] Bugfix: multiple late elements that fall in one session accidentally created a triggering empty window

----


> EventTimeSessionWindows trigger for empty windows when dropping late events
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-4134
>                 URL: https://issues.apache.org/jira/browse/FLINK-4134
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.0.3
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> It seems like EventTimeSessionWindows sometimes trigger for empty windows. The behavior is observed in connection with dropping late events:
> {code}
> stream
>  .keyBy("sessionKey")
>  .window(EventTimeSessionWindows.withGap(Time.milliseconds(100)))
>  .allowedLateness(Time.milliseconds(0))
>  .apply(new ValidatingWindowFunction())
>  .print();
> {code}
> I wrote a generator that generates events for several parallel sessions and that allows to reproduce the error. For now, I can share this generator privately for debugging purposes, but my plan is to use the generator as basis for an integration test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)