[GitHub] sijie commented on issue #1292: Avoid acquiring closeLock.readLock() on every add/read operation

[GitBox <gi...@apache.org>]

sijie commented on issue #1292: Avoid acquiring closeLock.readLock() on every add/read operation
URL: https://github.com/apache/bookkeeper/pull/1292#issuecomment-375912701
 
 
   I am not sure that is right. If I remembered correctly, the lock is prevent client try to obtain a connect when closing. I think the reason you don't want contention in this level, because it is shared across all pcbc tools. you might consider pushing one level or two levels down.
   
   However if my understanding is wrong, you might also want to remove the read write lock variable, since we don't really need a rw lock after your change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services