You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/07/01 22:26:53 UTC

[kudu-CR] [wip] ranger kms key provider

Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18692


Change subject: [wip] ranger kms key provider
......................................................................

[wip] ranger kms key provider

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
R src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/CMakeLists.txt
20 files changed, 408 insertions(+), 59 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#13).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
44 files changed, 1,057 insertions(+), 195 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/13
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 13
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#15).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
44 files changed, 1,090 insertions(+), 217 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/15
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#5).

Change subject: Integrate Kudu with Ranger KMS
......................................................................

Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch finishes implements a Ranger KMS key provider and the Ranger
client, and also wraps up initialization of keys and policies in
MiniRanger and MiniRangerKMS.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/env_posix.cc
38 files changed, 934 insertions(+), 170 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 17: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 21:12:51 +0000
Gerrit-HasComments: No

[kudu-CR] [wip] ranger kms key provider

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#4).

Change subject: [wip] ranger kms key provider
......................................................................

[wip] ranger kms key provider

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
R src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/CMakeLists.txt
22 files changed, 513 insertions(+), 88 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 10:

(18 comments)

http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/consensus/raft_consensus_quorum-test.cc@141
PS7, Line 141:       if (server_key.empty()) {
             :         RETURN_NOT_OK(fs_manager->CreateInitialFileSyst
> nit: maybe, make them 'static const' or convert into 'constexpr const char*
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto
File src/kudu/fs/fs.proto:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto@39
PS8, Line 39:   optional string server_key = 3;
            : 
            :   // Initialization vector for the server key.
            :   optional string server_key_iv = 4;
            : 
            :   // Server key version.
            :   optional string server_key_version = 5;
> Are these going to be printed out into the logs or elsewhere by calling pb_
They are going to be printed out, but as this is an encrypted key, I don't think it's worth redacting (and it might be useful to print it for debugging purposes).


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc@132
PS8, Line 132: Key provider
> Does it make sense to add a validator to catch misconfigurations at earlier
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc@135
PS8, Line 135: const char* /*n*/, const std::string& value) {
             :   return value == "default" || value ==
> This might be enforced by group flag validator (see examples for GROUP_FLAG
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/ranger_kms_key_provider.h
File src/kudu/fs/ranger_kms_key_provider.h:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/ranger_kms_key_provider.h@34
PS8, Line 34:     
> nit: wrong indent, should be 2 + 4 spaces from the beginning of the line
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/external_mini_cluster.cc
File src/kudu/mini-cluster/external_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/external_mini_cluster.cc@374
PS8, Line 374:           Su
> nit: wrong indent?
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/external_mini_cluster.cc@379
PS8, Line 379:           Su
> nit: wrong indent?
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/internal_mini_cluster.cc
File src/kudu/mini-cluster/internal_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/internal_mini_cluster.cc@160
PS8, Line 160:       KuduTest::GetEncryptionKey(&options->server_key,
             :                                  &options->server_key_iv,
> Here and in other KuduTest-derived classes: should these key_iv and key_ver
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms-test.cc
File src/kudu/ranger-kms/mini_ranger_kms-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms-test.cc@62
PS8, Line 62: 
            : 
> nit: could be shorten to
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms.cc
File src/kudu/ranger-kms/mini_ranger_kms.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms.cc@401
PS8, Line 401:         "s
> nit: wrong indent?
Done


http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/ranger-kms/ranger_kms_client.cc
File src/kudu/ranger-kms/ranger_kms_client.cc:

http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/ranger-kms/ranger_kms_client.cc@91
PS7, Line 91: 
> Does it make sense to add a CHECK/DCHECK or verify that at least one elemen
Done


http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/ranger-kms/ranger_kms_client.cc@97
PS7, Line 97: 
> nit for here and above: maybe, add a variable to refer to keys[0]?
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/server/CMakeLists.txt
File src/kudu/server/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/server/CMakeLists.txt@a90
PS8, Line 90: 
> Do we need to remove server/default_key_provider-test.cc file as well?
It was moved to fs/ too.


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-admin-test.cc@3054
PS8, Line 3054: 
> nit: usually, using 'true' or 'false' is more expressive for boolean flags 
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-tool-test.cc@1697
PS8, Line 1697:   ASSERT_EQ(canonicalized_uuid, fs.uuid());
              :   ASSERT_EQ(original_uuid, fs.uuid());
              :   ASSERT_EQ(server_key, fs.server_key());
              :   ASSERT_EQ(server_key_iv, fs.server_key_iv());
              :   ASSERT_EQ(server_key_version, fs.server_key_version());
> nit: in ASSERT_EQ, the expected value comes first -- otherwise, that's a bi
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-tool-test.cc@8089
PS8, Line 8089:   // TODO(abukor): Rewrite the test to make sure it works with encryption
              :   // enabled.
              :   /
> It would be great to add a blurb explaining why this test is skipped when e
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/tool_action_fs.cc
File src/kudu/tools/tool_action_fs.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/tool_action_fs.cc@243
PS8, Line 243:   }
             : 
> Is that intended that the emptiness of --server_key_version leads to not us
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc@208
PS8, Line 208: encryption_key_length
> Does it make sense to tag this flag as 'advanced'?
Not sure to be honest, why do you think it should be advanced?



-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 08:40:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 12:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto
File src/kudu/fs/fs.proto:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto@39
PS8, Line 39:   optional string server_key = 3;
            : 
            :   // Initialization vector for the server key.
            :   optional string server_key_iv = 4;
            : 
            :   // Server key version.
            :   optional string server_key_version = 5;
> Even if that's an encrypted key, printing it out in logs which might be shi
I think I prefer it to be logged by default, we can always change it later if we need to.


http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/tools/tool_action_fs.cc
File src/kudu/tools/tool_action_fs.cc:

http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/tools/tool_action_fs.cc@102
PS12, Line 102:   } else {
              :     return true;
              :   }
> readability nit: could drop 'else' and reduce to
Done


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc@208
PS8, Line 208: encryption_key_length
> Per an excerpts from grom flat_tags.h:
I think some people prefer higher bit-length, believing it to be more secure. Anyway, advanced doesn't require extra flags, so it doesn't hurt, changing it to advanced.


http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/util/test_util.h
File src/kudu/util/test_util.h:

http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/util/test_util.h@77
PS12, Line 77: const 
> nit: could drop 'const' once the method started returning 'void'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 18:37:20 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#7).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch finishes implements a Ranger KMS key provider and the Ranger
client, and also wraps up initialization of keys and policies in
MiniRanger and MiniRangerKMS.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/env_posix.cc
38 files changed, 934 insertions(+), 170 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#17).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
43 files changed, 1,033 insertions(+), 218 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/17
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 17:

> Build Started http://jenkins.kudu.apache.org/job/kudu-gerrit/26130/

BTW, what happened with mini_ranger_kms-test.cc?  It seems the test has been removed if looking into diff from PS13 to PS17.  Is that intentional?


-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 21:01:53 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Reviewed-on: http://gerrit.cloudera.org:8080/18692
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
43 files changed, 1,033 insertions(+), 218 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Attila Bukor: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 18
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 17:

> > Patch Set 17:
 > >
 > > > Build Started http://jenkins.kudu.apache.org/job/kudu-gerrit/26130/
 > >
 > > BTW, what happened with mini_ranger_kms-test.cc?  It seems the
 > test has been removed if looking into diff from PS13 to PS17.  Is
 > that intentional?
 > 
 > Yes, I removed it intentionally. That was basically a smoke test to
 > make sure RangerKMS starts up properly, but test-admin doesn't have
 > proper the permissions to get keys, so the recent change in the
 > parent commit broke this test. security-itest has a more complete
 > test, so I decided it's not worth fixing this test.

Thanks for the clarification!


-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 21:11:04 +0000
Gerrit-HasComments: No

[kudu-CR] [wip] ranger kms key provider

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#2).

Change subject: [wip] ranger kms key provider
......................................................................

[wip] ranger kms key provider

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
R src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.h
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/CMakeLists.txt
21 files changed, 415 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 17:

> Patch Set 17:
> 
> > Build Started http://jenkins.kudu.apache.org/job/kudu-gerrit/26130/
> 
> BTW, what happened with mini_ranger_kms-test.cc?  It seems the test has been removed if looking into diff from PS13 to PS17.  Is that intentional?

Yes, I removed it intentionally. That was basically a smoke test to make sure RangerKMS starts up properly, but test-admin doesn't have proper the permissions to get keys, so the recent change in the parent commit broke this test. security-itest has a more complete test, so I decided it's not worth fixing this test.


-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 21:06:55 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 8:

(20 comments)

http://gerrit.cloudera.org:8080/#/c/18692/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18692/7//COMMIT_MSG@13
PS7, Line 13: implemen
nit: drop 'finishes'?


http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/consensus/raft_consensus_quorum-test.cc@141
PS7, Line 141:         string server_key_iv = "42141312111009080706050403020100";
             :         string server_key_version = "kuduclusterkey@0";
nit: maybe, make them 'static const' or convert into 'constexpr const char* const'?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto
File src/kudu/fs/fs.proto:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto@39
PS8, Line 39:   optional string server_key = 3;
            : 
            :   // Initialization vector for the server key.
            :   optional string server_key_iv = 4;
            : 
            :   // Server key version.
            :   optional string server_key_version = 5;
Are these going to be printed out into the logs or elsewhere by calling pb_util::SecureShortDebugString() on InstanceMetadataPB?

Consider adding '(kudu.REDACT) = true' attribute for these then.


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc@132
PS8, Line 132: Valid values
Does it make sense to add a validator to catch misconfigurations at earlier stages?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc@135
PS8, Line 135: Must be set when 'encryption_key_provider' "
             :               "is set to 'ranger-kms'."
This might be enforced by group flag validator (see examples for GROUP_FLAG_VALIDATOR usages).


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs_manager.cc@214
PS8, Line 214: ranger_kms
nit: this isn't listed as a valid value in the description for the encryption_key_provider flag).


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/ranger_kms_key_provider.h
File src/kudu/fs/ranger_kms_key_provider.h:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/ranger_kms_key_provider.h@34
PS8, Line 34:     
nit: wrong indent, should be 2 + 4 spaces from the beginning of the line


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/external_mini_cluster.cc
File src/kudu/mini-cluster/external_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/external_mini_cluster.cc@374
PS8, Line 374:             
nit: wrong indent?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/external_mini_cluster.cc@379
PS8, Line 379:             
nit: wrong indent?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/internal_mini_cluster.cc
File src/kudu/mini-cluster/internal_mini_cluster.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/mini-cluster/internal_mini_cluster.cc@160
PS8, Line 160:       mini_master->mutable_options()->server_key_iv = "42141312111009080706050403020100";
             :       mini_master->mutable_options()->server_key_version = "kuduclusterkey@0";
Here and in other KuduTest-derived classes: should these key_iv and key_version be retrieved by calling some methods of KuduTest, similar to KuduTest::GetEncryptionKey() above?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms-test.cc
File src/kudu/ranger-kms/mini_ranger_kms-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms-test.cc@62
PS8, Line 62:   Status status = cluster_->ranger_kms()->GetKeys();
            :   ASSERT_OK(status);
nit: could be shorten to

ASSERT_OK(cluster_->ranger_kms()->GetKeys());


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms.cc
File src/kudu/ranger-kms/mini_ranger_kms.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/ranger-kms/mini_ranger_kms.cc@401
PS8, Line 401:           
nit: wrong indent?


http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/ranger-kms/ranger_kms_client.cc
File src/kudu/ranger-kms/ranger_kms_client.cc:

http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/ranger-kms/ranger_kms_client.cc@91
PS7, Line 91: keys[0]
Does it make sense to add a CHECK/DCHECK or verify that at least one element is present in 'keys' before attempting to access the very first element?


http://gerrit.cloudera.org:8080/#/c/18692/7/src/kudu/ranger-kms/ranger_kms_client.cc@97
PS7, Line 97: keys[0]
nit for here and above: maybe, add a variable to refer to keys[0]?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/server/CMakeLists.txt
File src/kudu/server/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/server/CMakeLists.txt@a90
PS8, Line 90: 
Do we need to remove server/default_key_provider-test.cc file as well?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-admin-test.cc@3054
PS8, Line 3054: 1
nit: usually, using 'true' or 'false' is more expressive for boolean flags like this


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-tool-test.cc@1697
PS8, Line 1697:   ASSERT_EQ(fs.uuid(), canonicalized_uuid);
              :   ASSERT_EQ(fs.uuid(), original_uuid);
              :   ASSERT_EQ(fs.server_key(), server_key);
              :   ASSERT_EQ(fs.server_key_iv(), server_key_iv);
              :   ASSERT_EQ(fs.server_key_version(), server_key_version);
nit: in ASSERT_EQ, the expected value comes first -- otherwise, that's a bit hard to read the error message if these asserts trigger (if ever)


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/kudu-tool-test.cc@8089
PS8, Line 8089:   if (FLAGS_encrypt_data_at_rest) {
              :     GTEST_SKIP();
              :   }
It would be great to add a blurb explaining why this test is skipped when encryption-at-rest is enabled


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/tool_action_fs.cc
File src/kudu/tools/tool_action_fs.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/tools/tool_action_fs.cc@243
PS8, Line 243:       && !FLAGS_server_key_iv.empty()
             :       && !FLAGS_server_key_version.empty())
Is that intended that the emptiness of --server_key_version leads to not using the value specified for --server_key?  If that's intended, maybe it makes sense to add a group validator for the --server_key, --server_key_iv, and --server_key_version flags?


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc@208
PS8, Line 208: encryption_key_length
Does it make sense to tag this flag as 'advanced'?



-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 21 Jul 2022 22:13:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 12: Code-Review+2

(5 comments)

Overall looks good to me, just a few nits.

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto
File src/kudu/fs/fs.proto:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto@39
PS8, Line 39:   optional string server_key = 3;
            : 
            :   // Initialization vector for the server key.
            :   optional string server_key_iv = 4;
            : 
            :   // Server key version.
            :   optional string server_key_version = 5;
> They are going to be printed out, but as this is an encrypted key, I don't 
Even if that's an encrypted key, printing it out in logs which might be shipped elsewhere from a node doesn't benefit security.  With '(kudu.REDACT) = true' you just have more control whether those are printed or not.  Up to you, though.


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/server/CMakeLists.txt
File src/kudu/server/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/server/CMakeLists.txt@a90
PS8, Line 90: 
> It was moved to fs/ too.
Ah, indeed -- thanks for the pointer.


http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/tools/tool_action_fs.cc
File src/kudu/tools/tool_action_fs.cc:

http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/tools/tool_action_fs.cc@102
PS12, Line 102:   } else {
              :     return true;
              :   }
readability nit: could drop 'else' and reduce to

if (...) {
  return false;
}
return true;


http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/util/env_posix.cc@208
PS8, Line 208: encryption_key_length
> Not sure to be honest, why do you think it should be advanced?
Per an excerpts from grom flat_tags.h:
  * '... These flags are for advanced users or debugging purposes ...'
  * '... they're also likely to be used only rarely ...'

I thought this flag isn't going to be set in a regular basis, rather only in rare cases if people has some certain need/requirements.

Do we expect the size of the encryption key to be changed from the default 128 in pretty much any Kudu cluster based on pure preference of people hosting the cluster?  If yes, then it's not 'advanced', I guess.

Probably, the best way to decide is to understand under what circumstances people are going to change this setting.


http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/util/test_util.h
File src/kudu/util/test_util.h:

http://gerrit.cloudera.org:8080/#/c/18692/12/src/kudu/util/test_util.h@77
PS12, Line 77: const 
nit: could drop 'const' once the method started returning 'void'



-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 18:06:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#11).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
42 files changed, 1,020 insertions(+), 183 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#12).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
44 files changed, 1,056 insertions(+), 195 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/12
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#10).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
42 files changed, 1,020 insertions(+), 183 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#8).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/env_posix.cc
37 files changed, 935 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [wip] ranger kms key provider

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#3).

Change subject: [wip] ranger kms key provider
......................................................................

[wip] ranger kms key provider

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
R src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/CMakeLists.txt
22 files changed, 504 insertions(+), 88 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#6).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch finishes implements a Ranger KMS key provider and the Ranger
client, and also wraps up initialization of keys and policies in
MiniRanger and MiniRangerKMS.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/env_posix.cc
38 files changed, 934 insertions(+), 170 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#14).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
44 files changed, 1,088 insertions(+), 215 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/14
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 13: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto
File src/kudu/fs/fs.proto:

http://gerrit.cloudera.org:8080/#/c/18692/8/src/kudu/fs/fs.proto@39
PS8, Line 39:   optional string server_key = 3;
            : 
            :   // Initialization vector for the server key.
            :   optional string server_key_iv = 4;
            : 
            :   // Server key version.
            :   optional string server_key_version = 5;
> I think I prefer it to be logged by default, we can always change it later 
SGTM: it seems that adding attributes to fields is a backward-compatible compatible change in that sense



-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 13
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 18:48:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#16).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_migration-itest.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
43 files changed, 1,032 insertions(+), 217 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/16
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 16
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18692 )

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................


Patch Set 17: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 22 Jul 2022 22:04:02 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3385 Integrate Kudu with Ranger KMS

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18692

to look at the new patch set (#9).

Change subject: KUDU-3385 Integrate Kudu with Ranger KMS
......................................................................

KUDU-3385 Integrate Kudu with Ranger KMS

To make data at rest encryption actually secure, the cluster key needs
to be generated and stored securely. Hadoop/Ranger KMS was chosen for
this purpose, which are API compatible.

This patch implements a Ranger KMS key provider and the Ranger client,
and also wraps up initialization of keys and policies in MiniRanger and
MiniRangerKMS. KeyProvider interface and its default mplementation had
to be moved into fs/ from server/ to avoid introducing circular
dependencies.

It also removes the 'hidden' tag from the encryption-related flags as it
is now safe to use.

Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/fs/CMakeLists.txt
R src/kudu/fs/default_key_provider-test.cc
A src/kudu/fs/default_key_provider.h
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
R src/kudu/fs/key_provider.h
A src/kudu/fs/ranger_kms_key_provider.cc
A src/kudu/fs/ranger_kms_key_provider.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/ranger-kms/CMakeLists.txt
A src/kudu/ranger-kms/mini_ranger_kms-test.cc
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger-kms/mini_ranger_kms.h
M src/kudu/ranger-kms/mini_ranger_kms_configs.h
A src/kudu/ranger-kms/ranger_kms_client.cc
A src/kudu/ranger-kms/ranger_kms_client.h
M src/kudu/ranger/mini_ranger.cc
M src/kudu/ranger/mini_ranger.h
M src/kudu/ranger/mini_ranger_configs.h
M src/kudu/server/CMakeLists.txt
D src/kudu/server/default_key_provider.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base_options.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/util/env_posix.cc
37 files changed, 929 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18692/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I681bed35f44cd03c1db69847c04faa460745f206
Gerrit-Change-Number: 18692
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)