You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/23 16:31:27 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #10583: [Feature][Docs] Add links to metrics docs
EricGao888 opened a new pull request, #10583:
URL: https://github.com/apache/dolphinscheduler/pull/10583
## Purpose of the pull request
- Add links to metrics docs.
## Brief change log
- Add links to metrics docs.
- related: #10582
## Verify this pull request
- Verified by manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10583: [docs] Add links to metrics docs
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10583:
URL: https://github.com/apache/dolphinscheduler/pull/10583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10583: [Feature][Docs] Add links to metrics docs
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10583:
URL: https://github.com/apache/dolphinscheduler/pull/10583#issuecomment-1165126271
@zhongjiajie @Tianqi-Dotes Could you plz take a look when available? Thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10583: [Feature][Docs] Add links to metrics docs
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10583:
URL: https://github.com/apache/dolphinscheduler/pull/10583#discussion_r905876031
##########
docs/configs/docsdev.js:
##########
@@ -283,6 +283,15 @@ export default {
title: 'Security',
link: '/en-us/docs/dev/user_doc/guide/security.html',
},
+ {
+ title: 'Metrics Related',
Review Comment:
I prefer "meteics" instead of "meteics related" to keep it simple and easy to read. But i do not have strong oppoin here
```suggestion
title: 'Metrics',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10583: [docs] Add links to metrics docs
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10583:
URL: https://github.com/apache/dolphinscheduler/pull/10583#discussion_r905879179
##########
docs/configs/docsdev.js:
##########
@@ -283,6 +283,15 @@ export default {
title: 'Security',
link: '/en-us/docs/dev/user_doc/guide/security.html',
},
+ {
+ title: 'Metrics Related',
Review Comment:
Sure, I updated it with `Metrics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org