You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/14 04:32:53 UTC
[GitHub] [incubator-superset] serenajiang commented on a change in pull
request #9138: [mypy] Enforcing typing for db_engine_specs
serenajiang commented on a change in pull request #9138: [mypy] Enforcing typing for db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/9138#discussion_r379246820
##########
File path: superset/db_engine_specs/base.py
##########
@@ -77,7 +83,7 @@ class TimeGrain(NamedTuple): # pylint: disable=too-few-public-methods
class TimestampExpression(
ColumnClause
): # pylint: disable=abstract-method,too-many-ancestors,too-few-public-methods
- def __init__(self, expr: str, col: ColumnClause, **kwargs):
+ def __init__(self, expr: str, col: ColumnClause, **kwargs: Any) -> None:
Review comment:
PEP484 says to type `**kwargs` and `*args` as the type of the arguments, not the type of `kwargs` (`dict`) and `args`(`tuple`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org