You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2007/07/26 06:41:31 UTC

[jira] Created: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
-------------------------------------------------------------------------------------------------------------------------

                 Key: AXIS2-3018
                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
             Project: Axis 2.0 (Axis2)
          Issue Type: Bug
          Components: jaxws
            Reporter: Jarek Gawor


ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Roy A. Wood Jr. (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516090 ] 

Roy A. Wood Jr. commented on AXIS2-3018:
----------------------------------------

Hi Jarek,
  This makes sense for the GET_PORT case (otherwise SEI is null). But this will only work when there is one endpoint for the service description.

> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Ann Robinson
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Roy A. Wood Jr. (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516441 ] 

Roy A. Wood Jr. commented on AXIS2-3018:
----------------------------------------

Hi Lin,

After our discussion this morning ( and your comments on this issue) I agree that it  would be acceptable for the user get back just the first endpoint given the conditions specified.

> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Ann Robinson
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated AXIS2-3018:
-------------------------------

    Attachment: AXIS2-3018.patch

The attached patch changes the updateEndpointDescription() function to consider the SEI class to lookup for an existing EndpointDescription object.


> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated AXIS2-3018:
-------------------------------

    Attachment: AXIS2-3018.patch

Here's an updated patch. 

> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: AXIS2-3018.patch, AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Assigned: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Ann Robinson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ann Robinson reassigned AXIS2-3018:
-----------------------------------

    Assignee: Ann Robinson

> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Ann Robinson
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Resolved: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved AXIS2-3018.
--------------------------------

       Resolution: Fixed
    Fix Version/s: nightly
                   1.3

Patch committed to 1_3 branch: Committed revision 561207.


> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>             Fix For: 1.3, nightly
>
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Updated: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated AXIS2-3018:
-------------------------------

    Attachment:     (was: AXIS2-3018.patch)

> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Assigned: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reassigned AXIS2-3018:
----------------------------------

    Assignee: Jarek Gawor  (was: Ann Robinson)

> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516413 ] 

Lin Sun commented on AXIS2-3018:
--------------------------------

Hi Roy,

>From the Java 5 API doc for this method - getPort(Class<T> serviceEndpointInterface)

The parameter serviceEndpointInterface specifies the service endpoint interface that is supported by the returned proxy. In the implementation of this method, the JAX-WS runtime system takes the responsibility of selecting a protocol binding (and a port) and configuring the proxy accordingly. 

In the patch, if there are multiple endpoints for the service description, the axis2 implementation would just return the first one it found (i.e descs[0]).   I think this is okay, and if the user wants to specify which endpoint for the service description to use, the user can use this method -- getPort(QName portName, Class<T> serviceEndpointInterface) instead.

Lin





> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Ann Robinson
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Commented: (AXIS2-3018) ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516592 ] 

Jarek Gawor commented on AXIS2-3018:
------------------------------------

The new patch is now committed to trunk: Committed revision 561202.


> ServiceDescriptionImpl.updateEndpointDescription() re-creates EndpointDescription objects when portQName is not specified
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-3018
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3018
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: jaxws
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: AXIS2-3018.patch
>
>
> ServiceDescriptionImpl.updateEndpointDescription() looks for existing EndpointDescription objects only when portQName is specified. When portQName is not specified, the updateEndpointDescription() function will create a new EndpointDescription each time it is called. This can lead to a memory leak when the client configuration context is reused because somehow the EndpointDescription objects remain retained (through AxisConfiguration). I can provide more info on that later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org