You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/18 02:28:54 UTC
[GitHub] [flink] klion26 opened a new pull request #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
klion26 opened a new pull request #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893
## What is the purpose of the change
Make RocksDB the default store for timers when using `RocksDBStateBackend`.
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
- RocksDBStateBackendConfigTest.java
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-576536039
Thanks for checking the performance impact @klion26.
From the result we will have a (expected) 3-5% decline of the `RocksStateBackendBenchmark` on our codespeed center. @pnowojski JFYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575978822
Azure CI failed because of irrelevant case, created [an issue](https://issues.apache.org/jira/browse/FLINK-15661) to track it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575997482
@carp84 thanks for the review. addressed the comments. run two end-to-end tests locally, from the memory dump, it runs as expected.
The caller of `test_resume_savepoint.sh` has set the timer storage explicit, so I don't change them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on a change in pull request #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#discussion_r368291470
##########
File path: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh
##########
@@ -47,7 +47,7 @@ ORIGINAL_DOP=$1
NEW_DOP=$2
STATE_BACKEND_TYPE=${3:-file}
STATE_BACKEND_FILE_ASYNC=${4:-true}
-STATE_BACKEND_ROCKS_TIMER_SERVICE_TYPE=${5:-heap}
+STATE_BACKEND_ROCKS_TIMER_SERVICE_TYPE=${5:-rocks}
Review comment:
Changing the default here to rocks makes sense, while I'm not sure the impact to e2e test (many cases will use rocksdb timer instead). Could you also include e2e tests in travis run to make sure no surprise? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145096915 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:bacb74fbc862936397c5762d04271769685b178b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4476 TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
Hash:bacb74fbc862936397c5762d04271769685b178b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145108439 TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145096915) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461)
* bacb74fbc862936397c5762d04271769685b178b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145108439) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4476)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-576165144
Thank you for fixing this.
Looks good to me, +1 to merge this...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
carp84 commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-576001726
What's more, I could see there might be a performance impact for our micro benchmark. Could you run some test locally to check against the `RocksStateBackendBenchmark` and post the result here? @klion26 Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145096915 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145096915) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145096915 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:bacb74fbc862936397c5762d04271769685b178b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4476 TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
Hash:bacb74fbc862936397c5762d04271769685b178b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145108439 TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145096915) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461)
* bacb74fbc862936397c5762d04271769685b178b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145108439) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4476)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575969969
rebase the master to sync some doc generation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 commented on a change in pull request #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#discussion_r368504806
##########
File path: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh
##########
@@ -47,7 +47,7 @@ ORIGINAL_DOP=$1
NEW_DOP=$2
STATE_BACKEND_TYPE=${3:-file}
STATE_BACKEND_FILE_ASYNC=${4:-true}
-STATE_BACKEND_ROCKS_TIMER_SERVICE_TYPE=${5:-heap}
+STATE_BACKEND_ROCKS_TIMER_SERVICE_TYPE=${5:-rocks}
Review comment:
The [result](https://travis-ci.com/flink-ci/flink/builds/145155686) of the e2e test verification (#10905) looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145096915 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:bacb74fbc862936397c5762d04271769685b178b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4476 TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
Hash:bacb74fbc862936397c5762d04271769685b178b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145108439 TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145096915) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461)
* bacb74fbc862936397c5762d04271769685b178b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145108439) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4476)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] carp84 merged pull request #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
carp84 merged pull request #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145096915 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:bacb74fbc862936397c5762d04271769685b178b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bacb74fbc862936397c5762d04271769685b178b
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145096915) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461)
* bacb74fbc862936397c5762d04271769685b178b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] klion26 commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-576238885
Copied the benchmark result here
Before applying this change
```
Benchmark (stateBackend) Mode Cnt Score Error Units
RocksStateBackendBenchmark.stateBackends ROCKS thrpt 30 203.893 ± 1.580 ops/ms
RocksStateBackendBenchmark.stateBackends ROCKS_INC thrpt 30 201.896 ± 5.179 ops/ms
```
After applying this change
```
Benchmark (stateBackend) Mode Cnt Score Error Units
RocksStateBackendBenchmark.stateBackends ROCKS thrpt 30 194.382 ± 2.256 ops/ms
RocksStateBackendBenchmark.stateBackends ROCKS_INC thrpt 30 195.912 ± 2.151 ops/ms
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10893:
[FLINK-15637][state backends] Make RocksDB the default store for timers
when using RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575859797
<!--
Meta data
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145041173 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:2a07b12e4f943499075f42960fc84dd445df6f3c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454 TriggerType:PUSH TriggerID:2a07b12e4f943499075f42960fc84dd445df6f3c
Hash:d644b42865da92de5b84b807f373f53adbd7945b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d644b42865da92de5b84b807f373f53adbd7945b
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145091925 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:3c71f512cb2a8adfdfd094d794085cf883b39de9 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456 TriggerType:PUSH TriggerID:3c71f512cb2a8adfdfd094d794085cf883b39de9
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145096915 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
Hash:d55ffe03a45c1cf272e0e912450b9f391df73bc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461 TriggerType:PUSH TriggerID:d55ffe03a45c1cf272e0e912450b9f391df73bc7
-->
## CI report:
* 2a07b12e4f943499075f42960fc84dd445df6f3c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145041173) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4454)
* d644b42865da92de5b84b807f373f53adbd7945b UNKNOWN
* 3c71f512cb2a8adfdfd094d794085cf883b39de9 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145091925) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4456)
* d55ffe03a45c1cf272e0e912450b9f391df73bc7 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145096915) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10893: [FLINK-15637][state
backends] Make RocksDB the default store for timers when using
RocksDBStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10893: [FLINK-15637][state backends] Make RocksDB the default store for timers when using RocksDBStateBackend
URL: https://github.com/apache/flink/pull/10893#issuecomment-575858109
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2a07b12e4f943499075f42960fc84dd445df6f3c (Sat Jan 18 02:32:30 UTC 2020)
**Warnings:**
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15637).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services