[GitHub] [lucene-solr] HoustonPutman commented on pull request #2083: SOLR-15001 Docker: require init_var_solr.sh

[GitBox <gi...@apache.org>]

HoustonPutman commented on pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#issuecomment-728316337


   I agree with not liking the cumbersome Test class, the reason I added it was to allow for easy inclusion/exclusion rules for test cases. I think this PR loses that functionality. You could add it back in with 
   
   ```groovy
   testsInclude = propertyOrEnvOrDefault("solr.docker.tests.include", "SOLR_DOCKER_TESTS_INCLUDE", "")
   testsExclude = propertyOrEnvOrDefault("solr.docker.tests.exclude", "SOLR_DOCKER_TESTS_EXCLUDE", "")
   ```
   
   You would just need to edit `help/docker.txt` to make sure it's up to date with how to use the test inputs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org