You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/07/01 15:15:37 UTC
[GitHub] [hudi] leesf commented on a change in pull request #3206: [HUDI-2115] FileSlices in the filegroup is not descending by timestamp
leesf commented on a change in pull request #3206:
URL: https://github.com/apache/hudi/pull/3206#discussion_r662380290
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileGroup.java
##########
@@ -62,9 +60,7 @@
public HoodieFileGroup(HoodieFileGroup fileGroup) {
this.timeline = fileGroup.timeline;
this.fileGroupId = fileGroup.fileGroupId;
- this.fileSlices = new TreeMap<>(fileGroup.fileSlices.entrySet().stream()
- .map(e -> Pair.of(e.getKey(), new FileSlice(e.getValue())))
- .collect(Collectors.toMap(Pair::getKey, Pair::getValue)));
+ this.fileSlices = new TreeMap<>(fileGroup.fileSlices);
Review comment:
would you please write an unit test to cover the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org