[GitHub] drill pull request: DRILL-2385: Count on complex objects failed with missing...

[parthchandra <gi...@git.apache.org>]

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/501#discussion_r65275657
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java ---
    @@ -196,8 +196,8 @@ public IterOutcome next() {
                 releaseAssets();
                 done = true;  // have any future call to next() return NONE
     
    -            if (mutator.isNewSchema()) {
    -              // This last reader has a new schema (e.g., we have a zero-row
    +            if (mutator.isNewTopLevelSchema()) {
    --- End diff --
    
    I don't see why this condition is better than isNewSchema. Looks to me that any time this is true, isNewSchema will also be true. Why don't we want to check the condition that the deeperSchema might have changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---