You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/16 14:27:08 UTC
[GitHub] [incubator-nuttx] michallenc opened a new pull request #2004: FlexCAN driver for i.MX RT1060 MCU
michallenc opened a new pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004
## Summary
Adds FlexCAN driver for i.MX RT1060 MCU and the support for imxrt1060-evk board.
## Testing
Verified on imxrt1060-evk board, tested againts [MicroZed APO board](https://cw.fel.cvut.cz/b192/_media/courses/b35apo/en/semestral/mz_apo-datasheet-en.pdf)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506971235
##########
File path: arch/arm/src/imxrt/imxrt_flexcan.h
##########
@@ -0,0 +1,125 @@
+/************************************************************************************
+ * arch/arm/src/imxrt/imxrt_flexcan.h
+ *
+ * Copyright (C) 2020 Gregory Nutt. All rights reserved.
Review comment:
@patacongo Thank you for clarifying this. I´ll make the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-710861454
Hi @michallenc
Add a blank line above the line the line that failed OR move the comment to the right to align with the previous command's alignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-710861454
Hi @michallenc
Add a blank line above the line the line that failed OR moved the comment to the right to align with with the previous command's alignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506956787
##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
##########
@@ -0,0 +1,96 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
+ *
+ *
+ * Redistribution and use in source and binary forms, with or without
Review comment:
@xiaoxiang781216 Sure. Just by adding
* Copyright (C) 2020 Gregory Nutt. All rights reserved.
* Author: Michal Lenc <le...@fel.cvut.cz>
*
* Based on: arch/arm/src/s32k1xx/s32k1xx_flexcan.c
or is there a need to change the whole Apache license as in [Coding Standard](https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#cfilestructure)? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-711030002
Hi @davids5 and @Ouss4
Thank you for your advices and help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506956787
##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
##########
@@ -0,0 +1,96 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
+ *
+ *
+ * Redistribution and use in source and binary forms, with or without
Review comment:
@xiaoxiang781216 Sure. Just by adding
* Copyright (C) 2020 Gregory Nutt. All rights reserved.
* Author: Michal Lenc <le...@fel.cvut.cz>
*
* Based on: arch/arm/src/s32k1xx/s32k1xx_flexcan.h
or is there a need to change the whole Apache license as in [Coding Standard](https://cwiki.apache.org/confluence/display/NUTTX/Coding+Standard#cfilestructure)? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-710989380
The build is failing becase imxrt1060-evk/canfd defconfig's is using old configurations.
Please refresh it by running: `./tools/refresh.sh --silent imxrt1060-evk:canfd`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506971222
##########
File path: arch/arm/src/imxrt/hardware/imxrt_flexcan.h
##########
@@ -0,0 +1,481 @@
+/****************************************************************************************************
+ * arch/arm/src/imxrt/hardware/imxrt_flexcan.h
+ *
+ * Copyright (C) 2020 Gregory Nutt. All rights reserved.
+ * Author: Michal Lenc <le...@fel.cvut.cz>
+ *
+ * Based on: arch/arm/src/s32k1xx/hardware/s32k1xx_flexcan.h
Review comment:
Another one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-710861454
Hi @michallenc
Add a blank line above the line the line that failed OR move the comment to the right to align with with the previous command's alignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506966420
##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
##########
@@ -0,0 +1,96 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
+ *
+ *
+ * Redistribution and use in source and binary forms, with or without
Review comment:
@acassis Thanks, it´s done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506954588
##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
##########
@@ -0,0 +1,96 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
+ *
+ *
+ * Redistribution and use in source and binary forms, with or without
Review comment:
@michallenc Please change the copright to apache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506968457
##########
File path: arch/arm/src/imxrt/imxrt_flexcan.h
##########
@@ -0,0 +1,125 @@
+/************************************************************************************
+ * arch/arm/src/imxrt/imxrt_flexcan.h
+ *
+ * Copyright (C) 2020 Gregory Nutt. All rights reserved.
Review comment:
need change too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506960771
##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
##########
@@ -0,0 +1,96 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
+ *
+ *
+ * Redistribution and use in source and binary forms, with or without
Review comment:
Yes, it needs to be changed to Apache license
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-710842856
Any idea about arch/arm/src/imxrt/hardware/rt106x/imxrt106x_ccm.h warnings? As far as I can see it is the same coding style as it is the mainline. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506954588
##########
File path: boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
##########
@@ -0,0 +1,96 @@
+/****************************************************************************
+ * boards/arm/imxrt/imxrt1060-evk/src/imxrt_flexcan.c
+ *
+ *
+ * Redistribution and use in source and binary forms, with or without
Review comment:
Please change the copright to apache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#issuecomment-710989380
The build is failing because imxrt1060-evk/canfd defconfig's is using old configurations.
Please refresh it by running: `./tools/refresh.sh --silent imxrt1060-evk:canfd`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] michallenc commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
michallenc commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506969043
##########
File path: arch/arm/src/imxrt/imxrt_flexcan.h
##########
@@ -0,0 +1,125 @@
+/************************************************************************************
+ * arch/arm/src/imxrt/imxrt_flexcan.h
+ *
+ * Copyright (C) 2020 Gregory Nutt. All rights reserved.
Review comment:
@xiaoxiang781216 This one is based on s32k1xx_flexcan.h which is under the other (old) licence, so the code should retain the copyright. Or do I understand it wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2004: FlexCAN driver for i.MX RT1060 MCU
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #2004:
URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506970524
##########
File path: arch/arm/src/imxrt/imxrt_flexcan.h
##########
@@ -0,0 +1,125 @@
+/************************************************************************************
+ * arch/arm/src/imxrt/imxrt_flexcan.h
+ *
+ * Copyright (C) 2020 Gregory Nutt. All rights reserved.
Review comment:
>
>
> @xiaoxiang781216 This one is based on s32k1xx_flexcan.h which is under the other (old) licence, so the code should retain the copyright. Or do I understand it wrong?
Yes, but I am the author/coyright holder on that file. I have submitte both and ICLA and an SGA granting all NuttX software to the ASF. The license has not yet been changed on s32k1xx_flexcan.h but it should be.
I also grant you the right to change the header to Apache 2.0. No new files may come into the repository with the old BSD license. So if the header is not changed, the the PR will have to be declined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org