You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/16 12:01:05 UTC

[GitHub] tzulitai opened a new pull request #7504: [FLINK-10778] [tests] Extend TypeSerializerSnapshotMigrationTestBase to test migrating from multiple versions

tzulitai opened a new pull request #7504: [FLINK-10778] [tests] Extend TypeSerializerSnapshotMigrationTestBase to test migrating from multiple versions
URL: https://github.com/apache/flink/pull/7504
 
 
   ## What is the purpose of the change
   
   Prior to this PR, the `TypeSerializerSnapshotMigrationTestBase` was hardcoded to only test restoring from serializer snapshots generated in Flink 1.6.x.
   
   The main goal of this PR is to:
   - Make the test base version-aware so that multiple serializer snapshots can be tested
   - Extend all existing subclasses to test migrating from a 1.7.x snapshot (test snapshots are generated and added to this PR)
   - There are some other minor changes to the test base, to better match the actual usage / API contracts of the `TypeSerializerSnapshot` abstraction.
   
   ## Brief change log
   
   - 8303eec: Move `MigrationVersion` class to flink-core, since it'll be used by `TypeSerializerSnapshotMigrationTestBase`.
   - f5b587a: Makes `TypeSerializerSnapshotMigrationTestBase` version-aware. Test specifications can now define the version that the target test snapshot was taken in.
   - a13ae99 to 2196635: Some minor changes to the test base to better match usage & API contracts of the `TypeSerializerSnapshot` abstraction.
   - 3ba6a5e: Adds a utility `TestSpecifications` class that would help with de-duplicating code when specifying test specifications for multiple versions.
   - c5d20b7 to 200edc7: Adding `MigrationVersion.1.7` to the parameters of all existing `TypeSerializerSnapshotMigrationTestBase` subclasses, as well as generating the required test snapshot / data files for them.
   
   ## Verifying this change
   
   This is a refactoring of tests.
   All subclasses of `TypeSerializerSnapshotMigrationTestBase` should be passing still.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services