You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/30 01:00:15 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38842: [SPARK-41326] [CONNECT] Fix deduplicate is missing input

HyukjinKwon commented on code in PR #38842:
URL: https://github.com/apache/spark/pull/38842#discussion_r1035429164


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -466,6 +466,7 @@ def __init__(
     def plan(self, session: "SparkConnectClient") -> proto.Relation:
         assert self._child is not None
         plan = proto.Relation()
+        plan.deduplicate.input.CopyFrom(self._child.plan(session))

Review Comment:
   Let me just merge this for now and go forward.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org