You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/06 14:53:59 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26179: Add missing contrib classes to deprecated dictionaries
potiuk opened a new pull request, #26179:
URL: https://github.com/apache/airflow/pull/26179
The #26513 missed the classes that were added by deriving a new
class from the imported ones. This was mostly about non-consistent
spelling of class names.
This PR fixes it and brings missing contrib classes back.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #26179: Add missing contrib classes to deprecated dictionaries
Posted by GitBox <gi...@apache.org>.
ashb merged PR #26179:
URL: https://github.com/apache/airflow/pull/26179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26179: Add missing contrib classes to deprecated dictionaries
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26179:
URL: https://github.com/apache/airflow/pull/26179#issuecomment-1238274362
It's also black-formatted, so there are some extra parentheses added automatically by black to keep the line length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26179: Add missing contrib classes to deprecated dictionaries
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26179:
URL: https://github.com/apache/airflow/pull/26179#discussion_r963816686
##########
airflow/contrib/utils/__init__.py:
##########
@@ -24,281 +24,35 @@
warnings.warn("This module is deprecated. Please use `airflow.utils`.", DeprecationWarning, stacklevel=2)
__deprecated_classes = {
- 'aws_athena_hook': {
Review Comment:
This was copy&pasted by mistake :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26179: Add missing contrib classes to deprecated dictionaries
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26179:
URL: https://github.com/apache/airflow/pull/26179#issuecomment-1239396233
Would love that one too ... it makes airflow code so mych nicer to browse and understand what's still there in the "core".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org