You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "scala-steward-asf[bot] (via GitHub)" <gi...@apache.org> on 2024/04/07 00:09:36 UTC
[PR] Update scalapb-runtime to 0.11.15 [pekko-connectors-kafka]
scala-steward-asf[bot] opened a new pull request, #159:
URL: https://github.com/apache/pekko-connectors-kafka/pull/159
## About this PR
📦 Updates [com.thesamet.scalapb:scalapb-runtime](https://github.com/scalapb/ScalaPB) from `0.11.13` to `0.11.15`
📜 [GitHub Release Notes](https://github.com/scalapb/ScalaPB/releases/tag/v0.11.15) - [Changelog](https://github.com/scalapb/ScalaPB/blob/master/CHANGELOG.md) - [Version Diff](https://github.com/scalapb/ScalaPB/compare/v0.11.13...v0.11.15)
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/7ec418cd5441d449f037bca6d34326534c07a5dd/docs/repo-specific-configuration.md) file.
_Have a fantastic day writing Scala!_
<details>
<summary>âš™ Adjust future updates</summary>
Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
```
updates.ignore = [ { groupId = "com.thesamet.scalapb", artifactId = "scalapb-runtime" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "com.thesamet.scalapb", artifactId = "scalapb-runtime" }
}]
```
</details>
<sup>
labels: test-library-update, early-semver-minor, semver-spec-patch, version-scheme:early-semver, commit-count:1
</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update scalapb-runtime to 0.11.15 [pekko-connectors-kafka]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #159:
URL: https://github.com/apache/pekko-connectors-kafka/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update scalapb-runtime to 0.11.15 [pekko-connectors-kafka]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #159:
URL: https://github.com/apache/pekko-connectors-kafka/pull/159#discussion_r1554851529
##########
project/Versions.scala:
##########
@@ -28,10 +28,10 @@ object Versions {
// Keep .scala-steward.conf pin in sync
val kafkaVersion = "3.0.2"
val KafkaVersionForDocs = "30"
- // This should align with the ScalaTest version used in the Apache Pekko 1.0.x testkit
+ // This should align with the ScalaTest version used in the Apache Pekko 1.1.x testkit
Review Comment:
maybe the comment should be removed - we've been updating to latest scalatest on all module main branches - it is only the 1.0 release branches where we deliberately stuck with old jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update scalapb-runtime to 0.11.15 [pekko-connectors-kafka]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #159:
URL: https://github.com/apache/pekko-connectors-kafka/pull/159#discussion_r1554850704
##########
project/Versions.scala:
##########
@@ -28,10 +28,10 @@ object Versions {
// Keep .scala-steward.conf pin in sync
val kafkaVersion = "3.0.2"
val KafkaVersionForDocs = "30"
- // This should align with the ScalaTest version used in the Apache Pekko 1.0.x testkit
+ // This should align with the ScalaTest version used in the Apache Pekko 1.1.x testkit
Review Comment:
why? pekko-connectors-kafka is still targeting Pekko 1.0.x, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update scalapb-runtime to 0.11.15 [pekko-connectors-kafka]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #159:
URL: https://github.com/apache/pekko-connectors-kafka/pull/159#discussion_r1554852569
##########
project/Versions.scala:
##########
@@ -28,10 +28,10 @@ object Versions {
// Keep .scala-steward.conf pin in sync
val kafkaVersion = "3.0.2"
val KafkaVersionForDocs = "30"
- // This should align with the ScalaTest version used in the Apache Pekko 1.0.x testkit
+ // This should align with the ScalaTest version used in the Apache Pekko 1.1.x testkit
Review Comment:
right, seems this comment was added in https://github.com/apache/pekko-connectors-kafka/commit/7ef8dc48f68e357b2b16de3d8756d47a2527f703 but not really motivated there, I'm OK with removing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update scalapb-runtime to 0.11.15 [pekko-connectors-kafka]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #159:
URL: https://github.com/apache/pekko-connectors-kafka/pull/159#issuecomment-2041384601
not sure what that scalafmt failure is about, rebasing to see if #167 has any effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org