You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Zhe Zhang <zh...@apache.org> on 2015/11/06 01:33:37 UTC
Potential Gerrit support in review/commit flow
Hi HBase contributors,
The Hadoop community is considering adding Gerrit as a review / commit
tool. Since this will require support from the Apache Infra team, it makes
more sense if multiple projects can benefit from the effort.
The main benefit of Gerrit over ReviewBoard is better integration with git
and Jenkins. A Gerrit review request is created through a simple "git push"
instead of manually creating and uploading a diff file. Conflicts detection
and rebase can be done on the review UI as well. When the programmed commit
criteria are met (e.g. a code review +1 and a Jenkins verification),
committing can also be done with a single button click, or even
automatically.
This also just augments instead of replacing the current review / commit
flow. Every task will still start as a JIRA. Review comments can be made on
both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
also be directly committed through git command line (Gerrit will recognize
a direct commit and close the review request as long as a simple git hook
is installed:
https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
I wonder if the HBase community would be interested in moving on this
direction as well. Any feedback is much appreciated.
Thanks,
Zhe Zhang
Re: Potential Gerrit support in review/commit flow
Posted by Zhe Zhang <zh...@cloudera.com>.
Thanks for the feedback Sean. Please see my comments inline:
I'd want a subset of the community to be able to try out gerrit before
> we adopted it project wide.
That's definitely possible. If a contributor opts out from Gerrit he/she
should directly attach patch on JIRA.
>
> During that time, I would prefer it if all the committers didn't need
> to install the git hook while we're evaluating. Is it possible to
> configure gerrit to ignore direct commits to our repo without the
> plugin?
>
I haven't tried it but it should be possible. When a new Gerrit repo is
setup we can configure the commit permission from scratch (not necessarily
the same as the master repo).
If the concern is to avoid asking committers to change their git setup:
it's actually OK if they don't have the git hook. In that case they just
need to manually close the Gerrit review request.
> On Thu, Nov 5, 2015 at 6:33 PM, Zhe Zhang <zh...@apache.org> wrote:
> > Hi HBase contributors,
> >
> > The Hadoop community is considering adding Gerrit as a review / commit
> > tool. Since this will require support from the Apache Infra team, it
> makes
> > more sense if multiple projects can benefit from the effort.
> >
> > The main benefit of Gerrit over ReviewBoard is better integration with
> git
> > and Jenkins. A Gerrit review request is created through a simple "git
> push"
> > instead of manually creating and uploading a diff file. Conflicts
> detection
> > and rebase can be done on the review UI as well. When the programmed
> commit
> > criteria are met (e.g. a code review +1 and a Jenkins verification),
> > committing can also be done with a single button click, or even
> > automatically.
> >
> > This also just augments instead of replacing the current review / commit
> > flow. Every task will still start as a JIRA. Review comments can be made
> on
> > both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> > also be directly committed through git command line (Gerrit will
> recognize
> > a direct commit and close the review request as long as a simple git hook
> > is installed:
> > https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
> >
> > I wonder if the HBase community would be interested in moving on this
> > direction as well. Any feedback is much appreciated.
> >
> > Thanks,
> > Zhe Zhang
>
>
>
> --
> Sean
>
Re: Potential Gerrit support in review/commit flow
Posted by Sean Busbey <bu...@cloudera.com>.
I'd want a subset of the community to be able to try out gerrit before
we adopted it project wide.
During that time, I would prefer it if all the committers didn't need
to install the git hook while we're evaluating. Is it possible to
configure gerrit to ignore direct commits to our repo without the
plugin?
On Thu, Nov 5, 2015 at 6:33 PM, Zhe Zhang <zh...@apache.org> wrote:
> Hi HBase contributors,
>
> The Hadoop community is considering adding Gerrit as a review / commit
> tool. Since this will require support from the Apache Infra team, it makes
> more sense if multiple projects can benefit from the effort.
>
> The main benefit of Gerrit over ReviewBoard is better integration with git
> and Jenkins. A Gerrit review request is created through a simple "git push"
> instead of manually creating and uploading a diff file. Conflicts detection
> and rebase can be done on the review UI as well. When the programmed commit
> criteria are met (e.g. a code review +1 and a Jenkins verification),
> committing can also be done with a single button click, or even
> automatically.
>
> This also just augments instead of replacing the current review / commit
> flow. Every task will still start as a JIRA. Review comments can be made on
> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> also be directly committed through git command line (Gerrit will recognize
> a direct commit and close the review request as long as a simple git hook
> is installed:
> https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
>
> I wonder if the HBase community would be interested in moving on this
> direction as well. Any feedback is much appreciated.
>
> Thanks,
> Zhe Zhang
--
Sean
Re: Potential Gerrit support in review/commit flow
Posted by Andrew Purtell <ap...@apache.org>.
+1, perhaps we can set up an autocommit workflow that only commits after
code review and a successful precommit build. This would automate much of
our community best practice.
On Thu, Nov 5, 2015 at 6:56 PM, Colin P. McCabe <cm...@apache.org> wrote:
> +1. Gerrit sounds great... definitely better than the old "attach a
> patch" workflow. I think it's worth trying out.
>
> On Thu, Nov 5, 2015 at 6:38 PM, Nick Dimiduk <nd...@apache.org> wrote:
> > Hi Zhe,
> >
> > This is promising! One question: is it possible to enfore fast-forward
> > only commits when pushing upstream via the web UI? A history full of
> merge
> > commits is not very palatable from our community perspective.
>
> Good point. I think there is a configuration to avoid merge commits--
> we should definitely make sure we're using that.
>
> Colin
>
> >
> > Thanks,
> > Nick
> >
> > On Thursday, November 5, 2015, Zhe Zhang <zh...@apache.org> wrote:
> >
> >> Hi HBase contributors,
> >>
> >> The Hadoop community is considering adding Gerrit as a review / commit
> >> tool. Since this will require support from the Apache Infra team, it
> makes
> >> more sense if multiple projects can benefit from the effort.
> >>
> >> The main benefit of Gerrit over ReviewBoard is better integration with
> git
> >> and Jenkins. A Gerrit review request is created through a simple "git
> push"
> >> instead of manually creating and uploading a diff file. Conflicts
> detection
> >> and rebase can be done on the review UI as well. When the programmed
> commit
> >> criteria are met (e.g. a code review +1 and a Jenkins verification),
> >> committing can also be done with a single button click, or even
> >> automatically.
> >>
> >> This also just augments instead of replacing the current review / commit
> >> flow. Every task will still start as a JIRA. Review comments can be
> made on
> >> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> >> also be directly committed through git command line (Gerrit will
> recognize
> >> a direct commit and close the review request as long as a simple git
> hook
> >> is installed:
> >> https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html
> ).
> >>
> >> I wonder if the HBase community would be interested in moving on this
> >> direction as well. Any feedback is much appreciated.
> >>
> >> Thanks,
> >> Zhe Zhang
> >>
>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: Potential Gerrit support in review/commit flow
Posted by "Colin P. McCabe" <cm...@apache.org>.
+1. Gerrit sounds great... definitely better than the old "attach a
patch" workflow. I think it's worth trying out.
On Thu, Nov 5, 2015 at 6:38 PM, Nick Dimiduk <nd...@apache.org> wrote:
> Hi Zhe,
>
> This is promising! One question: is it possible to enfore fast-forward
> only commits when pushing upstream via the web UI? A history full of merge
> commits is not very palatable from our community perspective.
Good point. I think there is a configuration to avoid merge commits--
we should definitely make sure we're using that.
Colin
>
> Thanks,
> Nick
>
> On Thursday, November 5, 2015, Zhe Zhang <zh...@apache.org> wrote:
>
>> Hi HBase contributors,
>>
>> The Hadoop community is considering adding Gerrit as a review / commit
>> tool. Since this will require support from the Apache Infra team, it makes
>> more sense if multiple projects can benefit from the effort.
>>
>> The main benefit of Gerrit over ReviewBoard is better integration with git
>> and Jenkins. A Gerrit review request is created through a simple "git push"
>> instead of manually creating and uploading a diff file. Conflicts detection
>> and rebase can be done on the review UI as well. When the programmed commit
>> criteria are met (e.g. a code review +1 and a Jenkins verification),
>> committing can also be done with a single button click, or even
>> automatically.
>>
>> This also just augments instead of replacing the current review / commit
>> flow. Every task will still start as a JIRA. Review comments can be made on
>> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
>> also be directly committed through git command line (Gerrit will recognize
>> a direct commit and close the review request as long as a simple git hook
>> is installed:
>> https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
>>
>> I wonder if the HBase community would be interested in moving on this
>> direction as well. Any feedback is much appreciated.
>>
>> Thanks,
>> Zhe Zhang
>>
Re: Potential Gerrit support in review/commit flow
Posted by Nick Dimiduk <nd...@apache.org>.
Hi Zhe,
This is promising! One question: is it possible to enfore fast-forward
only commits when pushing upstream via the web UI? A history full of merge
commits is not very palatable from our community perspective.
Thanks,
Nick
On Thursday, November 5, 2015, Zhe Zhang <zh...@apache.org> wrote:
> Hi HBase contributors,
>
> The Hadoop community is considering adding Gerrit as a review / commit
> tool. Since this will require support from the Apache Infra team, it makes
> more sense if multiple projects can benefit from the effort.
>
> The main benefit of Gerrit over ReviewBoard is better integration with git
> and Jenkins. A Gerrit review request is created through a simple "git push"
> instead of manually creating and uploading a diff file. Conflicts detection
> and rebase can be done on the review UI as well. When the programmed commit
> criteria are met (e.g. a code review +1 and a Jenkins verification),
> committing can also be done with a single button click, or even
> automatically.
>
> This also just augments instead of replacing the current review / commit
> flow. Every task will still start as a JIRA. Review comments can be made on
> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> also be directly committed through git command line (Gerrit will recognize
> a direct commit and close the review request as long as a simple git hook
> is installed:
> https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
>
> I wonder if the HBase community would be interested in moving on this
> direction as well. Any feedback is much appreciated.
>
> Thanks,
> Zhe Zhang
>
Re: Potential Gerrit support in review/commit flow
Posted by Elliott Clark <ec...@apache.org>.
I'm super in favor of a gerrit install.
Branches is the only thing that really comes to my mind, as being a pain.
So we'll need to have something like:
https://gist.github.com/vishvananda/2206428
On Thu, Nov 5, 2015 at 11:09 PM, Zhe Zhang <zh...@cloudera.com> wrote:
> >
> > One question: is it possible to enfore fast-forward only commits when
> > pushing upstream via the web UI? A history full of merge
> > commits is not very palatable from our community perspective.
>
>
> Thanks for the question Nick. Yes Gerrit can be configured to allow only
> fast-forward commits (that's actually the default "submit type" setting).
> When your change is outdated it will be highlighted and a "rebase" button
> will be provided.
>
> ---
> Zhe Zhang
>
> On Thu, Nov 5, 2015 at 4:33 PM, Zhe Zhang <zh...@apache.org> wrote:
>
> > Hi HBase contributors,
> >
> > The Hadoop community is considering adding Gerrit as a review / commit
> > tool. Since this will require support from the Apache Infra team, it
> makes
> > more sense if multiple projects can benefit from the effort.
> >
> > The main benefit of Gerrit over ReviewBoard is better integration with
> git
> > and Jenkins. A Gerrit review request is created through a simple "git
> push"
> > instead of manually creating and uploading a diff file. Conflicts
> detection
> > and rebase can be done on the review UI as well. When the programmed
> commit
> > criteria are met (e.g. a code review +1 and a Jenkins verification),
> > committing can also be done with a single button click, or even
> > automatically.
> >
> > This also just augments instead of replacing the current review / commit
> > flow. Every task will still start as a JIRA. Review comments can be made
> on
> > both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> > also be directly committed through git command line (Gerrit will
> recognize
> > a direct commit and close the review request as long as a simple git hook
> > is installed:
> > https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
> >
> > I wonder if the HBase community would be interested in moving on this
> > direction as well. Any feedback is much appreciated.
> >
> > Thanks,
> > Zhe Zhang
> >
>
Re: Potential Gerrit support in review/commit flow
Posted by Zhe Zhang <zh...@cloudera.com>.
>
> One question: is it possible to enfore fast-forward only commits when
> pushing upstream via the web UI? A history full of merge
> commits is not very palatable from our community perspective.
Thanks for the question Nick. Yes Gerrit can be configured to allow only
fast-forward commits (that's actually the default "submit type" setting).
When your change is outdated it will be highlighted and a "rebase" button
will be provided.
---
Zhe Zhang
On Thu, Nov 5, 2015 at 4:33 PM, Zhe Zhang <zh...@apache.org> wrote:
> Hi HBase contributors,
>
> The Hadoop community is considering adding Gerrit as a review / commit
> tool. Since this will require support from the Apache Infra team, it makes
> more sense if multiple projects can benefit from the effort.
>
> The main benefit of Gerrit over ReviewBoard is better integration with git
> and Jenkins. A Gerrit review request is created through a simple "git push"
> instead of manually creating and uploading a diff file. Conflicts detection
> and rebase can be done on the review UI as well. When the programmed commit
> criteria are met (e.g. a code review +1 and a Jenkins verification),
> committing can also be done with a single button click, or even
> automatically.
>
> This also just augments instead of replacing the current review / commit
> flow. Every task will still start as a JIRA. Review comments can be made on
> both JIRA and Gerrit and will be bi-directionally mirrored. Patches can
> also be directly committed through git command line (Gerrit will recognize
> a direct commit and close the review request as long as a simple git hook
> is installed:
> https://gerrit.googlecode.com/svn/documentation/2.0/user-changeid.html).
>
> I wonder if the HBase community would be interested in moving on this
> direction as well. Any feedback is much appreciated.
>
> Thanks,
> Zhe Zhang
>