You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2015/05/06 20:26:56 UTC
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/483
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF
Testing proved it was unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/remove-thrift-overload-if-unnecessary
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit 6dadd7b06b8643659cc38a226f05714bad1f50f3
Author: Jim King <ji...@simplivity.com>
Date: 2015-05-06T18:25:28Z
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF as testing proved it unnecessary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/483#issuecomment-99718040
I made some small changes to the TServerIntegrationTest to support testing THRIFT-1944 and rebased the fixup so there's still only one commit tag. The resulting build failed early so I recycled the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/483
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF
Testing proved it was unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/remove-thrift-overload-if-unnecessary
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit 929a7453034ef55434281908b3050b438c543da0
Author: Jim King <ji...@simplivity.com>
Date: 2015-05-06T18:25:28Z
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF as testing proved it unnecessary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...
Posted by jeking3 <gi...@git.apache.org>.
GitHub user jeking3 reopened a pull request:
https://github.com/apache/thrift/pull/483
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF
Testing proved it was unnecessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/remove-thrift-overload-if-unnecessary
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit 929a7453034ef55434281908b3050b438c543da0
Author: Jim King <ji...@simplivity.com>
Date: 2015-05-06T18:25:28Z
THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF as testing proved it unnecessary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---