You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Steven Cheng (JIRA)" <ji...@apache.org> on 2009/10/06 22:32:31 UTC
[jira] Created: (ZOOKEEPER-543) Tests for ZooKeeper examples
Tests for ZooKeeper examples
----------------------------
Key: ZOOKEEPER-543
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
Project: Zookeeper
Issue Type: New Feature
Components: tests
Affects Versions: 3.3.0
Reporter: Steven Cheng
Priority: Minor
Fix For: 3.3.0
Initial attempt to create ZooKeeper tests based on the example code on the website.
Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-543:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks steven!
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Assignee: Steven Cheng
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Patch Available (was: Open)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842190#action_12842190 ]
Hadoop QA commented on ZOOKEEPER-543:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431894/ZOOKEEPER-543.patch
against trunk revision 919640.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/133/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/133/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/133/console
This message is automatically generated.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842222#action_12842222 ]
Hadoop QA commented on ZOOKEEPER-543:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12438085/ZOOKEEPER-543.patch
against trunk revision 919706.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/79/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/79/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/79/console
This message is automatically generated.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Attachment: ZOOKEEPER-543.patch
C and Java version of testSequentialNodeData.
I found that almost all the tests in TestClient.cc need THREADED and this test also would not work without THREADED even though there's no reason it shouldn't.
Is there a reason for this?
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-543:
------------------------------------
Issue Type: Test (was: New Feature)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: Test
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835971#action_12835971 ]
Patrick Hunt commented on ZOOKEEPER-543:
----------------------------------------
Steven, only reason I can think of is that the mocks are not setup to handle sequential?
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Attachment: ZOOKEEPER-543.patch
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Patch Available (was: Open)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Patch Available (was: Open)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Open (was: Patch Available)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800976#action_12800976 ]
Hadoop QA commented on ZOOKEEPER-543:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421475/ZOOKEEPER-543.patch
against trunk revision 899383.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 208 release audit warnings (more than the trunk's current 207 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/104/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/104/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/104/console
This message is automatically generated.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Open (was: Patch Available)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762807#action_12762807 ]
Steven Cheng commented on ZOOKEEPER-543:
----------------------------------------
There's a bug in the node name processing, it tries to remove the full path from the string before parsing the id. The test still passes because of the 0 padding on the names. I'll fix this.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803574#action_12803574 ]
Steven Cheng commented on ZOOKEEPER-543:
----------------------------------------
Hi Mahadev, my original idea was to have small tests that tested the basic features needed to implement the examples without bringing in a full API.
testQueue tests that creating nodes works properly, in a similar way that a queue would use them.
testLock tests that create and delete work properly in a way that a lock would use them.
At this point I think that the queue and lock recipes do a good job of covering these cases, so these tests are probably not needed.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Attachment: ZOOKEEPER-543.patch
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-543:
------------------------------------
Status: Open (was: Patch Available)
waiting for steven to update the jira.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803110#action_12803110 ]
Mahadev konar commented on ZOOKEEPER-543:
-----------------------------------------
steven,
i am a little confused here. Is this the code that is testing something? Looks like you have a test for producer consumer classes? Dont we need to create an api (maybe copy from the examples in the docs) first and then test them? This could very well go into src/java/examples but am not sure what your code is trying to test. Can you be a little more specific?
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805743#action_12805743 ]
Steven Cheng commented on ZOOKEEPER-543:
----------------------------------------
Can do, shouldn't take too long I think.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803793#action_12803793 ]
Patrick Hunt commented on ZOOKEEPER-543:
----------------------------------------
I don't mind adding this, but aren't we testing this already in our tests? If not, wouldn't it be better to add these to existing/new test classes
that are more geared to the specific functionality being tested, rather than to some example which may change over time? Or is the
idea to point ppl to this "exampletest" class and therefore use it as a teaching aid, rather than just a test? Also, putting into say clienttest
class would enable testing under both standalone & quorum (for example). I guess my point is, why specifically "exampletest", rather than
just a test? Perhaps I'm just confused by the naming, again, I think the idea of adding more tests to cover things we don't already test
is a good idea so don't want to dis-wade you in general.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Open (was: Patch Available)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842212#action_12842212 ]
Steven Cheng commented on ZOOKEEPER-543:
----------------------------------------
Extra import was left in there for some reason.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-543:
-----------------------------------
Status: Patch Available (was: Open)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805616#action_12805616 ]
Patrick Hunt commented on ZOOKEEPER-543:
----------------------------------------
Steven that's great. Do you want to take a shot at adding similar verification to the c tests as well? Or
should we just consider this one as is? (meaning java only)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842878#action_12842878 ]
Mahadev konar commented on ZOOKEEPER-543:
-----------------------------------------
+1 a nice to have test case!
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Attachment: ZOOKEEPER-543.patch
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Attachment: ZOOKEEPER-543.patch
I took a look at ClientTest and testMultipleWatcherObjs seems to cover most of what the lock test does. There is a fair bit of overlap with testSequentialNodeNames and the queue test, but the queue test tests the data.
I moved the queue test into ClientTest and changed it to make it more similar to testSequentialNodeNames in this patch.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836076#action_12836076 ]
Hadoop QA commented on ZOOKEEPER-543:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431894/ZOOKEEPER-543.patch
against trunk revision 912052.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/118/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/118/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/118/console
This message is automatically generated.
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-543:
------------------------------------
Issue Type: Improvement (was: Test)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: Improvement
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Attachment: (was: ZOOKEEPER-543.patch)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-543) Tests for ZooKeeper examples
Posted by "Steven Cheng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Cheng updated ZOOKEEPER-543:
-----------------------------------
Status: Patch Available (was: Open)
> Tests for ZooKeeper examples
> ----------------------------
>
> Key: ZOOKEEPER-543
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-543
> Project: Zookeeper
> Issue Type: New Feature
> Components: tests
> Affects Versions: 3.3.0
> Reporter: Steven Cheng
> Assignee: Steven Cheng
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-543.patch, ZOOKEEPER-543.patch, ZOOKEEPER-543.patch
>
>
> Initial attempt to create ZooKeeper tests based on the example code on the website.
> Current plan is to test features used in examples using ZooKeeper calls directly. Another approach would be to make more usable abstractions such as those in src/recipes and test those.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.