You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2023/04/25 04:03:37 UTC
[GitHub] [doris] amorynan opened a new pull request, #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
amorynan opened a new pull request, #19033:
URL: https://github.com/apache/doris/pull/19033
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1521558442
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1522738764
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1523176175
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1523176238
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1522673086
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1521128003
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1521214931
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.07 seconds
stream load tsv: 430 seconds loaded 74807831229 Bytes, about 165 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230425062256_clickbench_pr_134553.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on a diff in pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #19033:
URL: https://github.com/apache/doris/pull/19033#discussion_r1176020458
##########
be/src/olap/types.cpp:
##########
@@ -259,7 +259,7 @@ TypeInfoPtr get_type_info(const TabletColumn* col) {
const auto* val_column = &col->get_sub_column(1);
TypeInfoPtr value_type = get_type_info(val_column);
MapTypeInfo* map_type_info = new MapTypeInfo(std::move(key_type), std::move(value_type));
- return create_static_type_info_ptr(map_type_info);
+ return create_dynamic_type_info_ptr(map_type_info);
Review Comment:
ARRAY did not has this problem , get_array_type_info(child_column->type(), iterations) which return a with
```static const ArrayTypeInfo*``` which is static .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1522734577
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19033:
URL: https://github.com/apache/doris/pull/19033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1521172570
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on a diff in pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on code in PR #19033:
URL: https://github.com/apache/doris/pull/19033#discussion_r1175987193
##########
be/src/olap/types.cpp:
##########
@@ -259,7 +259,7 @@ TypeInfoPtr get_type_info(const TabletColumn* col) {
const auto* val_column = &col->get_sub_column(1);
TypeInfoPtr value_type = get_type_info(val_column);
MapTypeInfo* map_type_info = new MapTypeInfo(std::move(key_type), std::move(value_type));
- return create_static_type_info_ptr(map_type_info);
+ return create_dynamic_type_info_ptr(map_type_info);
Review Comment:
consider ARRAY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #19033: [FIX](map-type)fix map regress test & create mapTypeInfo without delete
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #19033:
URL: https://github.com/apache/doris/pull/19033#issuecomment-1522999846
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org